syslogd: fix WITHOUT_INET builds #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 2d82b47 syslogd can't be built with `WITHOUT_INET` or `WITHOUT_INET6` build variables set, because `iovlist_truncate` is not defined but used. This change wraps the problematic `iovlist_truncate` call within ifdef directive.
|
This is correct. I did a minor tweak to the commit message to explain why this is ok better. |
freebsd-git
pushed a commit
that referenced
this pull request
Jun 13, 2021
Since 2d82b47 syslogd can't be built with `WITHOUT_INET` or `WITHOUT_INET6` build variables set, because `iovlist_truncate` is not defined but used. This change wraps the problematic `iovlist_truncate` call within ifdef directive. It's compiled out in this situation... Pull Request: #475 Reviewed by: imp@ (commit message slightly tweaked)
|
Commit f06fa6f is what's needed. |
rozhuk-im
pushed a commit
to rozhuk-im/freebsd
that referenced
this pull request
Nov 29, 2021
Since 2d82b47 syslogd can't be built with `WITHOUT_INET` or `WITHOUT_INET6` build variables set, because `iovlist_truncate` is not defined but used. This change wraps the problematic `iovlist_truncate` call within ifdef directive. It's compiled out in this situation... Pull Request: freebsd#475 Reviewed by: imp@ (commit message slightly tweaked) (cherry picked from commit f06fa6f) PR: 260098
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Dec 11, 2021
Since 2d82b47 syslogd can't be built with `WITHOUT_INET` or `WITHOUT_INET6` build variables set, because `iovlist_truncate` is not defined but used. This change wraps the problematic `iovlist_truncate` call within ifdef directive. It's compiled out in this situation... Pull Request: freebsd/freebsd-src#475 Reviewed by: imp@ (commit message slightly tweaked)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2d82b47 syslogd can't be built with
WITHOUT_INETorWITHOUT_INET6build variables set, becauseiovlist_truncateis notdefined but used.
This change wraps the problematic
iovlist_truncatecall within ifdefdirective.