Update ftpd.c to use va_end() #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va_start opened but not closed by va_end() pointed out by cppcheck
|
For bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257317 |
|
Acutally, that function is dead code. It's been #ifdef'd out ever since SVN r13139 in 1996. I'll just delete the whole thing. |
haiku-bot
pushed a commit
to haiku/haiku
that referenced
this pull request
Jul 29, 2021
as pointed out by cppcheck Notified upstream FreeBSD of issue. They realized this was dead code and ripped out. Syncing those specific changes only. freebsd/freebsd-src#517 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257317 https://cgit.freebsd.org/src/commit/?id=674400eb20b65369a88b1cb778d729bc297832c9 Change-Id: I4951fa3ce42798895a8222d927067640267d0bbc Reviewed-on: https://review.haiku-os.org/c/haiku/+/4214 Reviewed-by: Jérôme Duval <jerome.duval@gmail.com> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hardenedbsd-services
pushed a commit
to HardenedBSD/hardenedBSD
that referenced
this pull request
Feb 10, 2023
Co-authored-by: David Chisnall <davidchisnall@users.noreply.github.com> Co-authored-by: Robert Norton <1412774+rmn30@users.noreply.github.com> Co-authored-by: Nathaniel Wesley Filardo <nfilardo@microsoft.com> Co-authored-by: Istvan Haller <31476121+ihaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
va_start opened but not closed by va_end()
pointed out by cppcheck