e1000: Sync DPDK ich8lan #539
Conversation
|
@ricera is there any way to get guidance from intel on this file? The datasheets for the client parts are not very enlightening and it's hard to tell whether FreeBSD or OOT or DPDK is authoritative WRT clients. |
Basically not from within because of its age; but have you looked for the "software developers manuals" instead for those parts? In the past, that contained the stuff that was interesting to drivers, and that stuff wasn't included in the datasheets. Here's one for some old parts, but I don't know exactly what's in ich8lan: https://www.intel.com/content/dam/www/public/us/en/documents/manuals/pcie-gbe-controllers-open-source-manual.pdf |
|
For ICH8/9/10, it looks like you'd need "Intel® ICH 8/9/10 and 82566/82567/82562V: Developers Manual", but I can't get a link to it atm |
The problem in particular is with I218/I219 ULP there isn't really documentation on this stuff. I can't tell if the FreeBSD or DPDK code is newer in e1000_enable_ulp_lpt_lp(). |
I would assume the DPDK version is newer, and I also think we might have excluded ULP stuff in the FreeBSD driver. |
|
I was able to find it on archive.org http://web.archive.org/web/20170226164709/https://www.intel.com/content/dam/doc/manual/i-o-controller-hub-8-9-10-82566-82567-82562v-software-dev-manual.pdf This will be useful but doesn't seem to cover the LPT+ chipsets. |
|
Ok, I compared the freebsd in-kernel version with the DPDK and internal versions of the file, and it definitely looks like the DPDK version matches the internal one more closely; it's probably the more definitive file to use. As for I219-ish documentation, that might be when Intel stopped publishing external software documentation for them, I dunno. I have an internal one, but I haven't found any external-facing one yet. |
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
2 times, most recently
from
b9c5032
to
65d2de1
Compare
| @@ -1093,9 +1093,6 @@ em_if_attach_pre(if_ctx_t ctx) | |||
| } | |||
| } | |||
|
|
|||
| /* Disable ULP support */ | |||
| e1000_disable_ulp_lpt_lp(hw, true); | |||
There was a problem hiding this comment.
This is redundant, it is called in ich8lan setup via e1000_setup_init_funcs() above.
|
I've got this working on I219 now with https://reviews.freebsd.org/D32087 (!) |
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
65d2de1
to
928494d
Compare
|
@ricera I feel like I still don't have enough information to make any decisions on the majority of the changes In particular, this changeset results in:
The LSC to CSC change is interesting, Linux and any intel.com Linux and BSD drivers seem to not carry it. |
|
Tempted to close this based on my own and additional user testing, the code in main empirically works better. @ricera I am attempting to get "privileged access" with Intel, hopefully that will allow me to learn the details of I21x ULP |
|
After much trial and error the link flaps appear to be related to a particular old cable. Will need to trace through the shared code to see what is causing the hw init failure message. |
|
This branch looks like it may no longer be relevant. Is it still active? Or can it be closed? |
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
928494d
to
62d1f0b
Compare
This contains a possible regression for suspend/resume, break it out so users can help test. Obtained from: DPDK MFC after: 2 weeks Pull Request: freebsd#539
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
62d1f0b
to
e3883b9
Compare
This contains a possible regression for suspend/resume, break it out so users can help test. Obtained from: DPDK MFC after: 2 weeks Pull Request: freebsd#539
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
e3883b9
to
acd40b1
Compare
This contains a possible regression for suspend/resume, break it out so users can help test. Obtained from: DPDK MFC after: 2 weeks Pull Request: freebsd#539
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
acd40b1
to
7c046b4
Compare
This contains a possible regression for suspend/resume, break it out so users can help test. Obtained from: DPDK MFC after: 2 weeks Pull Request: freebsd#539
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
7c046b4
to
89f7da7
Compare
This contains a possible regression for suspend/resume, break it out so users can help test. Obtained from: DPDK MFC after: 2 weeks Pull Request: freebsd#539
kev009
force-pushed
the
e1000-DPDK-ich8lan
branch
from
89f7da7
to
b55be83
Compare
|
Committed relevant parts as d36fbdb |
This call only makes sense for ich8lan, and the shared code does it in e1000_setup_init_funcs() above this deletion. Obtained from: DPDK MFC after: 2 weeks Sponsored by: BBOX.io Pull Request: #539
This call only makes sense for ich8lan, and the shared code does it in e1000_setup_init_funcs() above this deletion. Obtained from: DPDK MFC after: 2 weeks Sponsored by: BBOX.io Pull Request: freebsd/freebsd-src#539
This call only makes sense for ich8lan, and the shared code does it in e1000_setup_init_funcs() above this deletion. Obtained from: DPDK Sponsored by: BBOX.io Pull Request: freebsd/freebsd-src#539 (cherry picked from commit d36fbdb)
This call only makes sense for ich8lan, and the shared code does it in e1000_setup_init_funcs() above this deletion. Obtained from: DPDK Sponsored by: BBOX.io Pull Request: freebsd/freebsd-src#539 (cherry picked from commit d36fbdb08ff567393a698aaf16f726275901ec96)
This contains a probable regression for suspend/resume and other issues on I219, break it out so users can help test.
Also of note, I left out two changes to the FreeBSD driver to try and opportunistically use ULP https://cgit.freebsd.org/src/diff/sys/dev/e1000/if_em.c?id=a4378873e9ce1b35b55378c21f8eae69e58c2525
@ricera