Use calloc and memset instead of malloc and bcopy #546
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtariDreams
force-pushed
the
calloc
branch
3 times, most recently
from
c3dc3b4
to
1346089
Compare
|
Looks good. Do you have a committer for this? |
|
Please rebase your patch and update the commit message. |
freebsd-git
pushed a commit
that referenced
this pull request
Mar 11, 2022
Pull Request: #546 MFC after: 1 week Sponsored by: NVIDIA Networking
freebsd-git
pushed a commit
that referenced
this pull request
Mar 11, 2022
Pull Request: #546 MFC after: 1 week Sponsored by: NVIDIA Networking
zxombie
pushed a commit
to CTSRD-CHERI/freebsd-morello
that referenced
this pull request
Mar 11, 2022
Pull Request: freebsd#546 MFC after: 1 week Sponsored by: NVIDIA Networking
zxombie
pushed a commit
to CTSRD-CHERI/freebsd-morello
that referenced
this pull request
Mar 11, 2022
Pull Request: freebsd#546 MFC after: 1 week Sponsored by: NVIDIA Networking
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Jun 4, 2022
Pull Request: freebsd/freebsd-src#546 MFC after: 1 week Sponsored by: NVIDIA Networking
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Jun 4, 2022
Pull Request: freebsd/freebsd-src#546 MFC after: 1 week Sponsored by: NVIDIA Networking
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Jun 4, 2022
Pull Request: freebsd/freebsd-src#546 MFC after: 1 week Sponsored by: NVIDIA Networking
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Jun 4, 2022
Pull Request: freebsd/freebsd-src#546 MFC after: 1 week Sponsored by: NVIDIA Networking
|
No I do not have a committer for this, sadly. |
Calloc is more efficient, and bcopy is out of use and we should be using memset instead
|
The rest of geom tends to prefer bzero over memset. Since there's no clear win from one vs the other in the kernel, and to be consistent with the rest of geom, I'm going to close this pull request. All the other changes have landed. |
hardenedbsd-services
pushed a commit
to HardenedBSD/hardenedBSD
that referenced
this pull request
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.