Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping(8): Manual page cleanup and fixes #630

Closed
wants to merge 3 commits into from

Conversation

jlduran
Copy link
Contributor

@jlduran jlduran commented Nov 20, 2022

This Pull Request is divided in three commits:

  1. Appease mandoc and igor.
  2. Use example.com instead of foo.com.
  3. Update the IPv4 TTL section specifically for FreeBSD and remove old references.

Update the IPv4 TTL section specifically for FreeBSD.

FreeBSD changed the default TTL to 64 in
5639e86.

NetBSD and OpenBSD still use 255.

Remove some references of extinct operating systems.
@gbergling
Copy link
Contributor

The man page review is fine from my perspective. Can't speak for the TTL updates to the man page. I would create a differential for it, for the TTL updates.

@jlduran
Copy link
Contributor Author

jlduran commented Dec 1, 2022

Thank you!

I wonder if it helps, to visually understand the proposed change:

ping -4 -c1 www.freebsd.org
PING wfe2.nyi.freebsd.org (96.47.72.95): 56 data bytes
64 bytes from 96.47.72.95: icmp_seq=0 ttl=<64 - number of routers in the path> time=0.001 ms

--- wfe2.nyi.freebsd.org ping statistics ---
1 packets transmitted, 1 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 0.001/0.001/0.001/0.000 ms

Explanation:
The target system is FreeBSD (with net.inet.ip.ttl=64, the default). If you try to ping a target that uses 255, for example, OpenBSD:

ping -4 -c1 www.openbsd.org
PING www.openbsd.org (199.185.178.80): 56 data bytes
64 bytes from 199.185.178.80: icmp_seq=0 ttl=<255 - number of routers in the path> time=0.001 ms

--- www.openbsd.org ping statistics ---
1 packets transmitted, 1 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 0.001/0.001/0.001/0.000 ms

Or Windows (128):

ping -4 -c1 live.com
PING live.com (204.79.197.212): 56 data bytes
64 bytes from 204.79.197.212: icmp_seq=0 ttl=<128 - number of routers in the path> time=0.001 ms

--- live.com ping statistics ---
1 packets transmitted, 1 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 0.001/0.001/0.001/0.000 ms

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, including the TTL part.

freebsd-git pushed a commit that referenced this pull request Jan 2, 2023
* Appease mandoc -T lint and igor

* Use example.com for documentation

* Update the IPv4 TTL section.
  Update the IPv4 TTL section specifically for FreeBSD.
  FreeBSD changed the default TTL to 64 in
  5639e86.  NetBSD and OpenBSD still
  use 255.  Remove some references of extinct operating systems.

Reviewed by:	gbe (manpages), asomers
MFC after:	2 weeks
Pull Request:	#630
@jlduran jlduran closed this Jan 2, 2023
@jlduran jlduran deleted the fix-ping-8 branch January 2, 2023 02:07
freebsd-git pushed a commit that referenced this pull request Jan 27, 2023
* Appease mandoc -T lint and igor

* Use example.com for documentation

* Update the IPv4 TTL section.
  Update the IPv4 TTL section specifically for FreeBSD.
  FreeBSD changed the default TTL to 64 in
  5639e86.  NetBSD and OpenBSD still
  use 255.  Remove some references of extinct operating systems.

Reviewed by:	gbe (manpages), asomers
Pull Request:	#630

(cherry picked from commit 8eb4df9)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 15, 2023
* Appease mandoc -T lint and igor

* Use example.com for documentation

* Update the IPv4 TTL section.
  Update the IPv4 TTL section specifically for FreeBSD.
  FreeBSD changed the default TTL to 64 in
  5639e86.  NetBSD and OpenBSD still
  use 255.  Remove some references of extinct operating systems.

Reviewed by:	gbe (manpages), asomers
MFC after:	2 weeks
Pull Request:	freebsd/freebsd-src#630
@emaste emaste added the merged label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants