310.accounting: Verify process accounting is active before log rotation. #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if process accounting is active in the periodic script. If not, exit the periodic script indicating process accounting is not active instead of attempting to rotate the logs. onerotate_log turns accounting back on regardless of what accounting_enable in rc.conf is set to. PR: 267464
|
This looks good to me. |
|
https://reviews.freebsd.org/D37434 has another 'looks good' but wanted more review. |
igalic
approved these changes
Feb 28, 2023
|
OK. I'll push this in... But next time, if you have a review open, please add a line like since it saves me a step, which can really add up for these small commits. |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 28, 2023
This corrects a bug in which the daily periodic script '310.accounting' attempts to rotate logs via /etc/rc.d/accounting by calling onerotate_logs function. The rotate logs function turns accounting back on regardless of what acccounting_enable is set to in /etc/rc.conf. This is due to checkyesno always returning YES since rotate logs is called with the 'one' prefix. In effect, accounting will always be turned back on once a day even if it is disabled and stopped by hand. The fix was simple, just check if accounting is before rotating logs and if it is, don't attempt the rotate. PR: 267464 Reviewed by: imp, hps (lgtm, not approval), Mina Galić Pull Request: #648 Differential Revision: https://reviews.freebsd.org/D37434
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Mar 29, 2023
This corrects a bug in which the daily periodic script '310.accounting' attempts to rotate logs via /etc/rc.d/accounting by calling onerotate_logs function. The rotate logs function turns accounting back on regardless of what acccounting_enable is set to in /etc/rc.conf. This is due to checkyesno always returning YES since rotate logs is called with the 'one' prefix. In effect, accounting will always be turned back on once a day even if it is disabled and stopped by hand. The fix was simple, just check if accounting is before rotating logs and if it is, don't attempt the rotate. PR: 267464 Reviewed by: imp, hps (lgtm, not approval), Mina Galić Pull Request: freebsd/freebsd-src#648 Differential Revision: https://reviews.freebsd.org/D37434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if process accounting is active in the periodic script. If not, exit the periodic script indicating process accounting is not active instead of attempting to rotate the logs. onerotate_log turns accounting back on regardless of what accounting_enable in rc.conf is set to.
PR: 267464