Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename KB_DELAY to KBD_DELAY, enable use via KERNCONF, update docs #649

Closed
wants to merge 8 commits into from

Conversation

paepckehh
Copy link
Contributor

@paepckehh paepckehh commented Feb 18, 2023

new approach for #647

Allow the customization of KBD_DELAY as KERNCONF option, consistently rename existing KB_DELAY to KBD_DELAY to keep kernel option prefix consistent, add docs.

Existing KERNCONF options for the KBD_ prefix are:

[...]
# kbd options
KBD_DISABLE_KEYMAP_LOAD	opt_kbd.h
KBD_INSTALL_CDEV	opt_kbd.h
KBD_MAXRETRY		opt_kbd.h
KBD_MAXWAIT		opt_kbd.h
KBD_RESETDELAY		opt_kbd.h
KBDIO_DEBUG		opt_kbd.h
[...]

This unlocks:

  • allow to customize this parameter within user land less embedded and security appliances
  • allow to specify custom parameter-sets that are not supported via kbdcontrol fixed ranges/sets

No change in default behavior .

CI tests: D38603

add KBD_DELAY1 and KBD_DELAY2 description
allow to configure KBD_DELAY* via KERNCONF for user-land less embedded and security appliances
allow to configure KBD_DELAY via KERNCONF for user-land less embedded and security appliances
allow to configure KBD_DELAY* via KERNCONF for user-land less embedded and security appliances
add notice to kernel options KBD_DELAY1 and KBD_DELAY2
add section about  new kernel options KBD_DELAY1 and KBD_DELAY2
add section for new kernel keyboard options
@paepckehh
Copy link
Contributor Author

paepckehh commented Feb 21, 2023

updates done for atkbc.4 and UPDATING as requested,
added (optional) NOTES entries as proposal

@bsdimp
Copy link
Member

bsdimp commented Feb 21, 2023

I think we're super close now. I'll download it tomorrow (later in your day :) and see if there's anything last minute that needs changing, or if I need you to do anything else.

@paepckehh
Copy link
Contributor Author

I think we're super close now. I'll download it tomorrow (later in your day :) and see if there's anything last minute that needs changing, or if I need you to do anything else.

Thank you! Yes, GitHub really needs a local daylight indicator, flagging overlapping hours.
Hope we are still fast enough to MFC for 13.2?

@igalic
Copy link
Contributor

igalic commented Feb 21, 2023

it exists, but is only shown on the desktop view.

in addition, i live in Ireland (Republic) but as far as timezone selection goes, i get London, Edinburgh, Lisabon and Monrovia.

i think someone at GitHub needs to learn about the strained political relationships these islands have

@bsdimp
Copy link
Member

bsdimp commented Feb 25, 2023

Landing... folded a few commits together and had to fix some trailing white space.

@bsdimp bsdimp closed this Feb 25, 2023
freebsd-git pushed a commit that referenced this pull request Feb 25, 2023
Allow to configure KBD_DELAY* via KERNCONF for user-land less embedded
and security appliances

Reviewed by: imp (folded)
Pull Request: #649
freebsd-git pushed a commit that referenced this pull request Feb 25, 2023
add section about  new kernel options KBD_DELAY1 and KBD_DELAY2

Reviewed by: imp (small tweaks to man page)
Pull Request: #649
freebsd-git pushed a commit that referenced this pull request Feb 25, 2023
add section for new kernel keyboard options

Reviewed by: imp
Pull Request: #649
freebsd-git pushed a commit that referenced this pull request Feb 25, 2023
Add notice to kernel options KBD_DELAY1 and KBD_DELAY2

Reviewed by: imp (tweaked whitespace too)
Pull Request: #649
@bsdimp
Copy link
Member

bsdimp commented Feb 25, 2023

Also, next time, when updating, please update with a rebase rather than a merge...

@paepckehh
Copy link
Contributor Author

Also, next time, when updating, please update with a rebase rather than a merge.

Yes, sorry for that. Its always tempting to use the github web interface for small fixes
like this. But at the end its always a mess. For new requests I will migrate back to a native
git tool set & workflow.

Thank you for your great support!

@paepckehh paepckehh deleted the kbd_delay branch March 5, 2023 17:07
@paepckehh paepckehh restored the kbd_delay branch March 5, 2023 17:12
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 29, 2023
Allow to configure KBD_DELAY* via KERNCONF for user-land less embedded
and security appliances

Reviewed by: imp (folded)
Pull Request: freebsd/freebsd-src#649
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 29, 2023
add section about  new kernel options KBD_DELAY1 and KBD_DELAY2

Reviewed by: imp (small tweaks to man page)
Pull Request: freebsd/freebsd-src#649
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 29, 2023
add section for new kernel keyboard options

Reviewed by: imp
Pull Request: freebsd/freebsd-src#649
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 29, 2023
Add notice to kernel options KBD_DELAY1 and KBD_DELAY2

Reviewed by: imp (tweaked whitespace too)
Pull Request: freebsd/freebsd-src#649
@emaste emaste added the merged label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants