usr.sbin: Remove trailing semicolon #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please separate this into logical units: bhyve, lpr, pmccontrol and ppp as separate commits. I'll push that. Since this was submitted, we've added a note about strongly suggesting style changes be done only when prepping additional work in an area, so I'll let this one in under the old rules, but please consider that in the future. |
ElyesH
force-pushed
the
trailing_semicolon
branch
from
936791b
to
2d3ab06
Compare
Macros shouldn't use trailing semicolon. Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
ElyesH
force-pushed
the
trailing_semicolon
branch
from
2d3ab06
to
c05cf7d
Compare
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
freebsd-git
pushed a commit
that referenced
this pull request
Mar 15, 2023
Macros shouldn't use trailing semicolon. Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: #654
freebsd-git
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: #654
freebsd-git
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: #654
freebsd-git
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: #654
|
This looks good. I've merged it. |
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Apr 19, 2023
Macros shouldn't use trailing semicolon. Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: freebsd/freebsd-src#654
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: freebsd/freebsd-src#654
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: freebsd/freebsd-src#654
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed by: imp Pull Request: freebsd/freebsd-src#654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros shouldn't use trailing semicolon.