Update UPDATING in main #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uppercase H for the FreeBSD Handbook. Remove the white space that precedes a URI.
|
IMO The whitespace before the URL is intentional, to make it stand out. |
bsdimp
reviewed
May 1, 2023
bsdimp
reviewed
May 1, 2023
|
Only the capital h looks good to me. |
I think it's fairly outstanding as a separate paragraph for the address alone, but no argument.
|
|
NAK means "I'm explicitly saying no." so no to adding the version of FreeBSD to the -current UPDATING page... The extra spacing would be fine if there's blank lines... the URL I think is now longer than it was when it was added (or I'm just confused). |
FreeBSD-CURRENT, consistent with usage at pages such as <https://www.freebsd.org/releases/>. <freebsd#712 (comment)> relates.
grahamperrin
added a commit
to grahamperrin/freebsd-src
that referenced
this pull request
May 8, 2023
Consistent with conversation for <freebsd#712>.
grahamperrin
added a commit
to grahamperrin/freebsd-src
that referenced
this pull request
May 8, 2023
Consistent with conversation for <freebsd#712>.
I don't know the back history, but URLs that included |
This was referenced May 8, 2023
freebsd-git
pushed a commit
that referenced
this pull request
May 14, 2023
Reviewed by: imp Pull Request: #712
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2023
Reviewed by: imp Pull Request: freebsd/freebsd-src#712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uppercase H for the FreeBSD Handbook.
Change lowercase current to uppercase CURRENT.
Remove the white space that precedes the link to the relevant section of the Handbook. This is subtle; it improves usability for people who habitually triple-click to select a chunk of text (compared to a double-click to select a word).