ofed: Fix build with -Werror -Wdate-time #715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the e-mail address (previously submitted by line) you would like to appear in the commit message? |
hselasky
reviewed
Apr 12, 2023
emaste
reviewed
Apr 12, 2023
It should just carry though from the pull request, see e.g. 0b0ae2e |
|
Yea, git cherry-pick just does the right thing, except to add Pull Request: line (which you need to do manually) |
Thank you. It is not so often I pull from github into the source tree. |
igalic
force-pushed
the
fix/opensm-Wdate-time
branch
from
e36a3cc
to
b2c366e
Compare
|
removed the " build" |
FreeBSD 14 adds -Werror -Wdate-time to its build which trips up on opensm's build. Remove it from the code, as it doesn't really add much. This fixes builds WITH_OFED_EXTRA. PR: 270776 Upstream Pull-Request: linux-rdma/opensm#33
igalic
force-pushed
the
fix/opensm-Wdate-time
branch
from
b2c366e
to
711ac6d
Compare
freebsd-git
pushed a commit
that referenced
this pull request
May 1, 2023
This fixes builds WITH_OFED_EXTRA=YES . PR: 270776 Pull Request: #715 MFC after: 1 week Sponsored by: NVIDIA Networking
|
This pull request can be closed now! |
|
merged in d502d3f |
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Jul 20, 2023
This fixes builds WITH_OFED_EXTRA=YES . PR: 270776 Pull Request: freebsd/freebsd-src#715 MFC after: 1 week Sponsored by: NVIDIA Networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD 14 adds -Werror -Wdate-time to its build which trips up on opensm's build. Remove it from the code, as it doesn't really add much.
This fixes builds WITH_OFED_EXTRA.
PR: 270776
Upstream Pull-Request: linux-rdma/opensm#33