Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superio+nctgpio+ncthwm: Add support for new (weird) chips #719

Conversation

stephane-rochoy-stormshield
Copy link
Contributor

Modify superio(4) to:

  • extend its API to allow read/write to specific LDNs
  • add prefer/extid mechanism to deal with conflicting device IDs

Modify nctgpio(4) to:

  • use the prefer/extid mechanism
  • increase verbosity to direct i/o code path (iores != 0)
  • fix pin inversion configuration
  • allow forcing the use of indirect access channel via hint.gpio.0.flags=2
  • and support new (weird) chips

Add support for the following chips:

  • Nuvoton NCT5585D (GPIO)
  • Nuvoton NCT6796D-E (GPIO and hardware monitoring)
  • Nuvoton NCT6779 (GPIO and hardware monitoring)
  • Nuvoton NCT6116D (GPIO)
  • and Winbond 83627DHG (GPIO)

Man pages changes:

  • superio(4): Document supported Nuvoton and Winbond chips
  • nctgpio(4): Document supported Nuvoton chips
  • sysctl(9): Document formats for uint8_t and uint16_t that was missing from c3220d0

- Increase verbosity to direct i/o code path (iores != 0)
- Fix pin inversion configuration
- Allow forcing the use of indirect access channel via hint.gpio.0.flags=2
- Document the PREFER_INDIRECT_CHANNEL tunable in nctgpio(4)
Add support for the following chips:
- Nuvoton NCT5585D
- Nuvoton NCT6796D-E
- Nuvoton NCT6779
- Nuvoton NCT6116D
- and Winbond 83627DHG
Add support for the following chips:
- Nuvoton NCT6779D
- Nuvoton NCT6796D-E
@stephane-rochoy-stormshield
Copy link
Contributor Author

@bsdimp @emaste Do you have some time to review this PR? Even partially?

@bsdimp
Copy link
Member

bsdimp commented Jul 1, 2023

f03a7e5

@bsdimp bsdimp closed this Jul 1, 2023
@bsdimp bsdimp added the merged label Jul 1, 2023
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
Was missing from c3220d0.

Reviewed by: imp
Pull Request: #719
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
- Increase verbosity to direct i/o code path (iores != 0)
- Fix pin inversion configuration
- Allow forcing the use of indirect access channel via hint.gpio.0.flags=2
- Document the PREFER_INDIRECT_CHANNEL tunable in nctgpio(4)

Reviewed by: imp
Pull Request: #719
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
Add support for the following chips:
- Nuvoton NCT5585D
- Nuvoton NCT6796D-E
- Nuvoton NCT6779
- Nuvoton NCT6116D
- and Winbond 83627DHG

Reviewed by: imp
Pull Request: #719
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
Add support for the following chips:
- Nuvoton NCT6779D
- Nuvoton NCT6796D-E

Reviewed by: imp
Pull Request: #719
freebsd-git pushed a commit that referenced this pull request Jul 1, 2023
Reviewed by: imp
Pull Request: #719
@stephane-rochoy-stormshield
Copy link
Contributor Author

thanks!

bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
- Increase verbosity to direct i/o code path (iores != 0)
- Fix pin inversion configuration
- Allow forcing the use of indirect access channel via hint.gpio.0.flags=2
- Document the PREFER_INDIRECT_CHANNEL tunable in nctgpio(4)

Reviewed by: imp
Pull Request: freebsd/freebsd-src#719
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
Add support for the following chips:
- Nuvoton NCT5585D
- Nuvoton NCT6796D-E
- Nuvoton NCT6779
- Nuvoton NCT6116D
- and Winbond 83627DHG

Reviewed by: imp
Pull Request: freebsd/freebsd-src#719
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
Add support for the following chips:
- Nuvoton NCT6779D
- Nuvoton NCT6796D-E

Reviewed by: imp
Pull Request: freebsd/freebsd-src#719
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants