Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual page improvements to mpr(4), mps(4) and mpsutil(8) #729

Closed
wants to merge 3 commits into from

Conversation

tomhukins
Copy link
Contributor

No description provided.

@bsdimp
Copy link
Member

bsdimp commented May 4, 2023

these look good... maybe a bit too small per commit, but it's a bit of a hassle to fix that and it's not worth a round trip...af32969

@bsdimp bsdimp closed this May 4, 2023
freebsd-git pushed a commit that referenced this pull request May 4, 2023
freebsd-git pushed a commit that referenced this pull request May 4, 2023
Reviewed by: imp
Pull Request: #729
freebsd-git pushed a commit that referenced this pull request May 4, 2023
Spotted by running `mandoc -Tlint usr.sbin/mpsutil/mpsutil.8`.

Reviewed by: imp
Pull Request: #729
@tomhukins
Copy link
Contributor Author

maybe a bit too small per commit

Thanks for the feedback, @bsdimp. I remember an earlier pull request of mine receiving the suggestion that I separate changes into smaller commits, but I guess I overdid it this time.

@tomhukins tomhukins deleted the mpr_mps_4 branch May 5, 2023 16:46
@bsdimp
Copy link
Member

bsdimp commented May 5, 2023

yea, it's a balance... it wasn't that bad, but next time a small bit bigger wouldn't be bad...

@emaste emaste added the merged label Jun 12, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 20, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 20, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 20, 2023
Spotted by running `mandoc -Tlint usr.sbin/mpsutil/mpsutil.8`.

Reviewed by: imp
Pull Request: freebsd/freebsd-src#729
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 21, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 21, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 21, 2023
Spotted by running `mandoc -Tlint usr.sbin/mpsutil/mpsutil.8`.

Reviewed by: imp
Pull Request: freebsd/freebsd-src#729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants