-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: efi_print_global only checks for the first 5 letters of "Driver" #738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, nice find! To make the code more readable, could you please change the length numbers to strlen()
s instead? (I am pretty sure that the compiler would turn these into number constants at build time).
Looks good to me... The practical effect of this, however, is limited since we'd filter more things through this gate, but nothing standard conflicts... It's a good fix, and I'll land it. |
So I can't find the name/email that I've used in the past to land your commits, and this commit has the 'github' anonymous email address. |
Oh, wait, in the past I've used |
This is still good. |
Please change the email address to a non-users.noreply.github.com based address. |
Done! |
fc2592c
to
dd80f32
Compare
As a result, it is only really checking for the word Drive, making "Drive" appended to anything else considered for efi env.
Merged as 39ae24e. Thanks! |
As a result, it is only really checking for the word Drive, making "Drive" appended to anything else considered for efi env. Reviewed by: imp, kevans Pull Request: #738
As a result, it is only really checking for the word Drive, making "Drive" appended to anything else considered for efi env. Reviewed by: imp, kevans Pull Request: freebsd/freebsd-src#738
As a result, it is only really checking for the word Drive, making "Drive" appended to anything else considered for efi env.