Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: efi_print_global only checks for the first 5 letters of "Driver" #738

Closed
wants to merge 1 commit into from

Conversation

AtariDreams
Copy link
Contributor

As a result, it is only really checking for the word Drive, making "Drive" appended to anything else considered for efi env.

@AtariDreams AtariDreams requested a review from bsdimp as a code owner May 8, 2023 21:49
Copy link
Member

@delphij delphij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice find! To make the code more readable, could you please change the length numbers to strlen()s instead? (I am pretty sure that the compiler would turn these into number constants at build time).

@bsdimp
Copy link
Member

bsdimp commented May 18, 2023

Looks good to me... The practical effect of this, however, is limited since we'd filter more things through this gate, but nothing standard conflicts... It's a good fix, and I'll land it.

@bsdimp
Copy link
Member

bsdimp commented May 18, 2023

So I can't find the name/email that I've used in the past to land your commits, and this commit has the 'github' anonymous email address.

@bsdimp
Copy link
Member

bsdimp commented May 18, 2023

Oh, wait, in the past I've used
Author: Alfonso gfunni234@gmail.com
is that still good?

@AtariDreams
Copy link
Contributor Author

Oh, wait, in the past I've used Author: Alfonso gfunni234@gmail.com is that still good?

This is still good.

@AtariDreams
Copy link
Contributor Author

@bsdimp

@ngie-eign
Copy link
Contributor

Please change the email address to a non-users.noreply.github.com based address.
If you use git config user.email, etc, then run git commit --reset-author --amend, it will update the authorship appropriately.

@AtariDreams
Copy link
Contributor Author

Please change the email address to a non-users.noreply.github.com based address. If you use git config user.email, etc, then run git commit --reset-author --amend, it will update the authorship appropriately.

Done!

@AtariDreams AtariDreams changed the title BUG: strncmp only checks for the first 5 letters of "Driver", not all 6. BUG: strncmp only checks for the first 5 letters of "Driver", not all 6 Jun 11, 2023
@AtariDreams AtariDreams changed the title BUG: strncmp only checks for the first 5 letters of "Driver", not all 6 Bug: strncmp only checks for the first 5 letters of "Driver", not all 6 Jun 11, 2023
@AtariDreams AtariDreams changed the title Bug: strncmp only checks for the first 5 letters of "Driver", not all 6 Bug: efi_print_global only checks for the first 5 letters of "Driver", not all 6 Jun 11, 2023
@AtariDreams AtariDreams force-pushed the histedit branch 2 times, most recently from fc2592c to dd80f32 Compare June 11, 2023 22:21
@AtariDreams AtariDreams changed the title Bug: efi_print_global only checks for the first 5 letters of "Driver", not all 6 Bug: efi_print_global only checks for the first 5 letters of "Driver" Jun 11, 2023
As a result, it is only really checking for the word Drive, making "Drive" appended to anything else considered for efi env.
@AtariDreams AtariDreams changed the title Bug: efi_print_global only checks for the first 5 letters of "Driver" bug: efi_print_global only checks for the first 5 letters of "Driver" Jun 11, 2023
@kevans91
Copy link
Contributor

Merged as 39ae24e. Thanks!

@kevans91 kevans91 closed this Jun 23, 2023
freebsd-git pushed a commit that referenced this pull request Jun 23, 2023
As a result, it is only really checking for the word Drive, making
"Drive" appended to anything else considered for efi env.

Reviewed by:	imp, kevans
Pull Request:	#738
@AtariDreams AtariDreams deleted the histedit branch June 23, 2023 10:29
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 14, 2023
As a result, it is only really checking for the word Drive, making
"Drive" appended to anything else considered for efi env.

Reviewed by:	imp, kevans
Pull Request:	freebsd/freebsd-src#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants