amdtemp: Fix missing 49 degree offset on current EPYC CPUs #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095 Tested by: mike.jakubik@gmail.com Sponsored by: https://www.patreon.com/valpackett
|
Hi, I am the one that reported the issue on Discord and tested the patch, works fine on a recent build of 13-STABLE running on a Lenovo SR635, can also test on a SR655 if need be. Would love to see this make it into stable as this is throwing off our monitoring software (Netdata). Thank You. |
|
@emaste ping |
mhorne
approved these changes
Jun 17, 2023
freebsd-git
pushed a commit
that referenced
this pull request
Jun 17, 2023
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095 Reviewed by: mhorne Tested by: mike.jakubik@gmail.com MFC after: 1 week Sponsored by: https://www.patreon.com/valpackett Pull Request: #754
|
This has landed in main, so closing. |
freebsd-git
pushed a commit
that referenced
this pull request
Jul 7, 2023
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095 Reviewed by: mhorne Tested by: mike.jakubik@gmail.com MFC after: 1 week Sponsored by: https://www.patreon.com/valpackett Pull Request: #754 (cherry picked from commit c1cbabe)
fichtner
pushed a commit
to opnsense/src
that referenced
this pull request
Aug 4, 2023
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095 Reviewed by: mhorne Tested by: mike.jakubik@gmail.com MFC after: 1 week Sponsored by: https://www.patreon.com/valpackett Pull Request: freebsd/freebsd-src#754 (cherry picked from commit c1cbabe)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 14, 2023
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095 Reviewed by: mhorne Tested by: mike.jakubik@gmail.com MFC after: 1 week Sponsored by: https://www.patreon.com/valpackett Pull Request: freebsd/freebsd-src#754
amotin
pushed a commit
to truenas/os
that referenced
this pull request
Dec 4, 2023
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095 Reviewed by: mhorne Tested by: mike.jakubik@gmail.com MFC after: 1 week Sponsored by: https://www.patreon.com/valpackett Pull Request: freebsd/freebsd-src#754 (cherry picked from commit c1cbabe) (cherry picked from commit eb08efb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an EPYC 7313P, the temperature reported by amdtemp was off, because the offset was not applied. Turns out it needs to be applied with one more condition: https://lkml.org/lkml/2023/4/13/1095
Tested by: mike.jakubik@gmail.com
Sponsored by: https://www.patreon.com/valpackett