ntp: Fixed undefined behavior of the shift operator #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d06alexandrov
force-pushed
the
ntp
branch
2 times, most recently
from
d9852c3
to
cb78e9f
Compare
Signed-off-by: Dmitriy Alexandrov <d06alexandrov@gmail.com>
|
CC @cschuber (gcc12 build failure in Cirrus-CI is due to PR271903 and can be ignored) |
|
I can look at this. |
freebsd-git
pushed a commit
that referenced
this pull request
Jun 9, 2023
L_LINT macro is used with negative numbers [i.e. L_LINT(time_freq, -MAXFREQ)], it could cause undefined behavior. It should be similar to the L_RSHIFT(v, n) macro. MFC after: 2 weeks Reviewed by: cy Pull Request: #769 Signed-off-by: Dmitriy Alexandrov <d06alexandrov@gmail.com>
|
This has been committed in af9ce4e. |
freebsd-git
pushed a commit
that referenced
this pull request
Jun 23, 2023
L_LINT macro is used with negative numbers [i.e. L_LINT(time_freq, -MAXFREQ)], it could cause undefined behavior. It should be similar to the L_RSHIFT(v, n) macro. MFC after: 2 weeks Reviewed by: cy Pull Request: #769 Signed-off-by: Dmitriy Alexandrov <d06alexandrov@gmail.com> (cherry picked from commit af9ce4e)
freebsd-git
pushed a commit
that referenced
this pull request
Jun 23, 2023
L_LINT macro is used with negative numbers [i.e. L_LINT(time_freq, -MAXFREQ)], it could cause undefined behavior. It should be similar to the L_RSHIFT(v, n) macro. MFC after: 2 weeks Reviewed by: cy Pull Request: #769 Signed-off-by: Dmitriy Alexandrov <d06alexandrov@gmail.com> (cherry picked from commit af9ce4e)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 12, 2023
L_LINT macro is used with negative numbers [i.e. L_LINT(time_freq, -MAXFREQ)], it could cause undefined behavior. It should be similar to the L_RSHIFT(v, n) macro. MFC after: 2 weeks Reviewed by: cy Pull Request: freebsd/freebsd-src#769 Signed-off-by: Dmitriy Alexandrov <d06alexandrov@gmail.com>
c-mauderer
pushed a commit
to c-mauderer/rtems
that referenced
this pull request
Jun 5, 2024
L_LINT macro is used with negative numbers [i.e. L_LINT(time_freq, -MAXFREQ)], it could cause undefined behavior. It should be similar to the L_RSHIFT(v, n) macro. MFC after: 2 weeks Reviewed by: cy Pull Request: freebsd/freebsd-src#769 Signed-off-by: Dmitriy Alexandrov <d06alexandrov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L_LINT macro is used with negative numbers (e.g
L_LINT(time_freq, -MAXFREQ)) so it could cause undefined behavior.So it should be similar to the L_RSHIFT(v, n) macro.