-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwpmc(4): instead of manual edition, use sysrc(8) #785
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good to me... |
good point actually, sysrc correctly quotes by itself |
Addition of a single alphanumeric value does not require enclosing quotation marks. Co-authored-by: Mina Galić <me+github@igalic.co>
Thank you both.
Side notes, for a future pull request for the manual page for sysrc(8):
(Now, I realise why I nearly always needed to look at the page two or three times (or look away) to make sense of, and find, the required knowledge.) Postscript
Instead: |
Exemplifying safe use of sysrc(8) has become commonplace in documentation such as the FreeBSD Handbook. Encourage its use. Consistency: 'the driver' (not 'this driver'). Co-authored-by: Mina Galić <me+github@igalic.co> Reviewed-by: imp, Mina Galić <me+github@igalic.co> Approved by: imp MFC after: 3 days Pull-request: #785
I dealt with merge conflicts once or twice in the past, but (sorry) recently I just haven't got the head space for anything beyond Git basics. If someone else would like to MFC, please go ahead, thanks. https://github.com/freebsd/freebsd-src/commits/stable/13/share/man/man4/hwpmc.4 Side note: https://github.com/refined-github/refined-github/blob/main/source/features/list-prs-for-file.tsx
|
Exemplifying safe use of sysrc(8) has become commonplace in documentation such as the FreeBSD Handbook. Encourage its use. Consistency: 'the driver' (not 'this driver'). Co-authored-by: Mina Galić <me+github@igalic.co> Reviewed-by: imp, Mina Galić <me+github@igalic.co> Approved by: imp MFC after: 3 days Pull-request: #785 (cherry picked from commit 666c54d)
First: thanks to Mina. Above, #785 (comment)
Looking at (tcsh)
URLs
I can't imagine why the Most recent history
|
Exemplifying safe use of sysrc(8) has become commonplace in documentation such as the FreeBSD Handbook. Encourage its use. Consistency: 'the driver' (not 'this driver'). Co-authored-by: Mina Galić <me+github@igalic.co> Reviewed-by: imp, Mina Galić <me+github@igalic.co> Approved by: imp MFC after: 3 days Pull-request: freebsd/freebsd-src#785
Exemplifying safe use of sysrc(8) has become commonplace in documentation such as the FreeBSD Handbook.