-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md: minor changes #788
Conversation
- Misspelled GitHub - angle bracket not escaped correctly - Double white spaces - White spaces at EOL
Two spaces are the one true way. |
I reinserted those spaces. Never used double spaces on purpose before but I guess it helps with readability |
fwiw, in the docs and on the website, we ask people to put one sentence per line. |
I thought we didn't do that for markdown documents because it messed up the rendering |
Some Markdown (in GitHub's case CommonMark) parsers may interpret the the sentence on a new line as a line break. If an empty line in between is used, then a paragraph is rendered. |
OK. One last issue. The author name is listed as
which is a nonsense email address. Do you have a real email address you'd like me to use? or I could do |
Oh I even checked my git config and it had my normal email. Anyway you can use dev(at)wuerfeldev.de |
Thanks! Pushed! |
- Misspelled GitHub - angle bracket not escaped correctly - Double white spaces - White spaces at EOL Reviewed by: imp Pull Request: #788
Reviewed by: imp Pull Request: #788
- Misspelled GitHub - angle bracket not escaped correctly - Double white spaces - White spaces at EOL Reviewed by: imp Pull Request: freebsd/freebsd-src#788
Reviewed by: imp Pull Request: freebsd/freebsd-src#788
Double white spaces