Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networking.7 : create network quickstart guide #833

Closed
wants to merge 11 commits into from

Conversation

concussious
Copy link
Contributor

@concussious concussious commented Aug 31, 2023

Now that the handbook has been moved to ports, I think it's very nice to have a network quickstart guide in-band, in base, in the system manual. If the user uses any of the following terms "man -k {network,networking,wifi,quickstart}" this page will come up, which is I think a very, very common use case for new users.

FreeBSD is the server star, but new users will need to play with it on their laptops before trying to use it in production, right?

Currently, this document explains connecting to a basic Ethernet network, USB tethering, a basic wifi network, scanning for wifi networks, and airplane mode, as well as linking to a few other relevant pages and sections, including the handbook.

grahamperrin added a commit to grahamperrin/freebsd-src that referenced this pull request Sep 2, 2023
https://bugs.freebsd.org/273530#c3

PR:	273530
Fixes:	08c9016 Add a manpage for the urndis driver.
Closes:	#4
Closes: freebsd#833
grahamperrin added a commit to grahamperrin/freebsd-src that referenced this pull request Sep 2, 2023
https://bugs.freebsd.org/273530#c3

PR:		273530
Fixes:		08c9016 Add a manpage for the urndis driver.
Signed-off-by:	Graham Perrin <grahamperrin@gmail.com>
Pull-request:	#4
Closes:		#4
Pull-request:	freebsd#833
Closes: 	freebsd#833
@grahamperrin
Copy link
Contributor

Sorry, ignore the urndis(4) pollution above. A consequence of me attempting to work with a PR in a fork in advance of a simple PR hereabouts.

share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
share/man/man7/networking.7 Outdated Show resolved Hide resolved
Comment on lines 30 to 20
.Sh NAME
.Nm networking ,
.Nm wifi
.Nd quickstart guide to connecting to a network
.Sh EXAMPLES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://man.freebsd.org/cgi/man.cgi?query=mdoc&sektion=7&manpath=freebsd-release#MANUAL_STRUCTURE in mdoc(7):

… convention dictates specifying at least the SYNOPSIS and DESCRIPTION sections, although this varies between manual sections. …

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't feel SYNOPSIS was relevant, most pages in section 7 didn't have them. My latest commit adds a description attempting to explain the nomenclature of interfaces

EDIT: s/relevant/appropriate

@concussious
Copy link
Contributor Author

Sorry, ignore the urndis(4) pollution above. A consequence of me attempting to work with a PR in a fork in advance of a simple PR hereabouts.

No, that's beautiful. I completely forgot about USB tethering. It should be mentioned here.

@concussious
Copy link
Contributor Author

I think it's less legible, but I rewrote the examples to format accordingly to style.mdoc(5), except without the depreciated Li macro. The guideline laid out there breaks a lot of mdoc conventions. The It macro is stated in mdoc(7) to be for individual commands and explicitly not entire lines. Also, subsections have their own macro, and I think they're appropriate for this use case. I have a copy with all the changes but the earlier formatting. Thoughts?

@bsdimp
Copy link
Member

bsdimp commented Dec 29, 2023

This commit needs to have a real email, not the noreply github one,

@igalic
Copy link
Contributor

igalic commented Jan 8, 2024

This commit needs to have a real email, not the noreply github one,

@concussious this is still not addressed

@concussious
Copy link
Contributor Author

This commit needs to have a real email, not the noreply github one,

@concussious this is still not addressed

I'm sorry, I thought that I did, and I don't understand.

@igalic
Copy link
Contributor

igalic commented Jan 9, 2024

concussious and others added 10 commits January 9, 2024 22:25
Now that the handbook has been moved to ports, I think it's very nice to have a network quickstart guide in-band, in base, in the system manual.
If the user uses any of the following terms "man -k {network,networking,wifi,quickstart}" this page will come up, which is I think a very common use case for new users.

Currently, this document explains connecting to a basic Ethernet network, a basic wifi network, scanning for wifi networks, and airplane mode, as well as linking to other sections, including the handbook
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
@concussious
Copy link
Contributor Author

Should I squash all these commits down to one like I was instructed to in the other thread? If so, will that negatively impact the commits coauthored with grahamperrin?

@igalic
Copy link
Contributor

igalic commented Jan 13, 2024

I asked @grahamperrin to chime in on whether he minds getting squashed. meanwhile, you can credit yourself as the author of this man page, if you so desire, on the bottom in an .Sh AUTHORS section.

@concussious
Copy link
Contributor Author

In such a case should we add him to the copyright at the top?

@igalic
Copy link
Contributor

igalic commented Jan 13, 2024

In such a case should we add him to the copyright at the top?

if you want, sure. your call

@bsdimp
Copy link
Member

bsdimp commented Mar 1, 2024

@bsdbcr Can you review this in more detail. It seems OK to me, but I'm not sure it belongs here. Thanks!

@bsdbcr
Copy link
Contributor

bsdbcr commented Mar 2, 2024

@bsdbcr Can you review this in more detail. It seems OK to me, but I'm not sure it belongs here. Thanks!

I've reviewed the changes. That looks solid and would be a good addition to our docs. Nothing to change, add, or complain about.

@concussious
Copy link
Contributor Author

I'd like it to say something better about turning wifi off. "Service netif stop" stops all networking, so local services that use networking as an ipc, such as musicpd, will also break.

Musicpd is maybe a bad example because you can configure it with a unix socket instead.

@concussious
Copy link
Contributor Author

I'm also concerned about I don't want to mislead anyone. The first step of connecting to a network is configuring a firewall, unless the entire machine is already behind a firewall, which I think is kind of an advanced use case.

@concussious
Copy link
Contributor Author

concussious commented Mar 3, 2024

EDIT: Sorry for the noise, it occurred to me that these files cannot be listed in intro(7) because they're all made conditionally. I have reverted the commit described in this comment below.

I just discovered intro(7) lists all the pages in section seven. Therefore, I have added this and everything else my 14.0-R-p3 machine has in /usr/share/man/man7/ to intro(7).

While there, I also zapped old tags, added spdx, and updated the history section to the same format used in the new hier(7).

@concussious
Copy link
Contributor Author

I'm not sure it belongs here.

Is it appropriate for netintro.4?

@bsdimp
Copy link
Member

bsdimp commented Apr 17, 2024

OK. This isn't getting any better, and hans't for a while. It looks good as is. I'll leave the intro issue for others.

@bsdimp bsdimp closed this Apr 17, 2024
freebsd-git pushed a commit that referenced this pull request Apr 17, 2024
Now that the handbook has been moved to ports, I think it's very nice to
have a network quickstart guide in-band, in base, in the system manual.
If the user uses any of the following terms "man -k
{network,networking,wifi,quickstart}" this page will come up, which is I
think a very common use case for new users.

Currently, this document explains connecting to a basic Ethernet
network, a basic wifi network, scanning for wifi networks, and airplane
mode, as well as linking to other sections, including the handbook

Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Reviewed by: imp, bcr, freebsd@igalic.co
Pull Request: #833
@concussious concussious deleted the networking.7 branch April 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants