Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man9: Fix two typos #839

Closed
wants to merge 2 commits into from
Closed

man9: Fix two typos #839

wants to merge 2 commits into from

Conversation

brokad
Copy link
Contributor

@brokad brokad commented Sep 11, 2023

No description provided.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jlduran
Copy link
Contributor

jlduran commented Sep 11, 2023

Don't forget to bump the date!

@lwhsu
Copy link
Member

lwhsu commented Sep 11, 2023

Just wanted to make sure, is the data in From of https://patch-diff.githubusercontent.com/raw/freebsd/freebsd-src/pull/839.patch is what you like to be in the Author field of the commit?

@emaste
Copy link
Member

emaste commented Sep 11, 2023

Don't forget to bump the date!

I'm not sure we document this adequately, but AFAIK we bump the date only when there's a material change in the man page -- e.g. when adding a new option to a command, or changing functionality. Bumping it isn't needed when fixing typos, grammar, etc.

@jlduran
Copy link
Contributor

jlduran commented Sep 11, 2023

Don't forget to bump the date!

I'm not sure we document this adequately, but AFAIK we bump the date only when there's a material change in the man page -- e.g. when adding a new option to a command, or changing functionality. Bumping it isn't needed when fixing typos, grammar, etc.

It is documented. I just didn't know about it:
https://docs.freebsd.org/en/books/fdp-primer/manual-pages/#manual-pages-markup-guidelines

@brokad
Copy link
Contributor Author

brokad commented Sep 12, 2023

Just wanted to make sure, is the data in From of https://patch-diff.githubusercontent.com/raw/freebsd/freebsd-src/pull/839.patch is what you like to be in the Author field of the commit?

Yep, that's good thanks 👍

@lwhsu lwhsu added the merged label Sep 12, 2023
@lwhsu lwhsu closed this Sep 12, 2023
freebsd-git pushed a commit that referenced this pull request Sep 12, 2023
MFC after:	3 days
Pull Request:	#839
freebsd-git pushed a commit that referenced this pull request Sep 12, 2023
freebsd-git pushed a commit that referenced this pull request Sep 19, 2023
MFC after:	3 days
Pull Request:	#839

(cherry picked from commit 06bac0d)
freebsd-git pushed a commit that referenced this pull request Sep 19, 2023
MFC after:	3 days
Pull Request:	#839

(cherry picked from commit ff9c4ab)
freebsd-git pushed a commit that referenced this pull request Sep 19, 2023
MFC after:	3 days
Pull Request:	#839

(cherry picked from commit 06bac0d)
freebsd-git pushed a commit that referenced this pull request Sep 19, 2023
MFC after:	3 days
Pull Request:	#839

(cherry picked from commit ff9c4ab)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Feb 2, 2024
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants