-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove $FreeBSD$: one line sh-pattern #870
Conversation
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good
@@ -86,9 +86,7 @@ mkimg_rebase() | |||
fi | |||
|
|||
if test $update = yes; then | |||
# Prevent keyword expansion when writing the keyword. | |||
(echo -n '# $'; echo -n FreeBSD; echo '$') > $baseline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted this three times today....
Pushed as 3b5c984 with a re-worded commit message. |
Remove the $FreeBSD$ pattern added to the tests, as well as fixing the mkimg_test.sh script to stop adding it when we rebase the tests. Reviewed by: imp, emaste Pull Request: #870
Remove the $FreeBSD$ pattern added to the tests, as well as fixing the mkimg_test.sh script to stop adding it when we rebase the tests. Reviewed by: imp, emaste Pull Request: freebsd/freebsd-src#870
Remove /^\s*#[#!]?\s*$FreeBSD$.*$\n/
cc/ @bsdimp