ping tests: Fix test on i386 platforms #874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically the problem isn't with 32-bit platforms, just i386. 32-bit arm has a 64-bit |
Ahhh. Let me change the commit message then. As we only care for i386 and armv7. |
Actually use INT_MAX (0x7fffffff), not UINT_MAX (0xffffffff) to avoid overflowing time_t and missing the test. Reported by: Jenkins Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D42268
jlduran
force-pushed
the
fix-32-bit-ping-test
branch
from
3dd3a0d
to
f833255
Compare
jlduran
changed the title
|
Merged! |
freebsd-git
pushed a commit
that referenced
this pull request
Oct 19, 2023
Actually use INT_MAX (0x7fffffff), not UINT_MAX (0xffffffff) to avoid overflowing time_t and missing the test. Reported by: Jenkins Reviewed by: markj Fixes: 5b8af90 ("ping: Add ATF-Python tests") Pull Request: #874 Differential Revision: https://reviews.freebsd.org/D42268
|
May I kindly request an MFC to stable/14: |
Fixed, thank you. |
freebsd-git
pushed a commit
that referenced
this pull request
Nov 3, 2023
Actually use INT_MAX (0x7fffffff), not UINT_MAX (0xffffffff) to avoid overflowing time_t and missing the test. Reported by: Jenkins Reviewed by: markj Fixes: 5b8af90 ("ping: Add ATF-Python tests") Pull Request: #874 Differential Revision: https://reviews.freebsd.org/D42268 (cherry picked from commit 24fe0cb)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Feb 24, 2024
Actually use INT_MAX (0x7fffffff), not UINT_MAX (0xffffffff) to avoid overflowing time_t and missing the test. Reported by: Jenkins Reviewed by: markj Fixes: 5b8af90 ("ping: Add ATF-Python tests") Pull Request: freebsd/freebsd-src#874 Differential Revision: https://reviews.freebsd.org/D42268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually use
INT_MAX(0x7fffffff), notUINT_MAX(0xffffffff) to avoid overflowingtime_tand missing the test.Reported by: Jenkins
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D42268
cc/ @markjdb