libsecureboot: be more verbose about validation failures #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these changes are good. |
|
Great! I guess we just need @sgerraty to glance quickly at the patch now :) |
|
Looks ok to me |
igalic
suggested changes
Dec 8, 2023
stephane-rochoy-stormshield
force-pushed
the
bearssl
branch
from
5415237
to
13fbbf0
Compare
freebsd-git
pushed a commit
that referenced
this pull request
Dec 10, 2023
Reviewed by: imp, sjg Pull Request: #916
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Mar 12, 2024
Reviewed by: imp, sjg Pull Request: freebsd/freebsd-src#916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
find_error_nameto be more explicit about the reason of validation failures. E.g.,