Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfsstat: update option strings in docs #958

Closed
wants to merge 1 commit into from

Conversation

llfw
Copy link
Contributor

@llfw llfw commented Dec 27, 2023

Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is already documented in DESCRIPTION), and add the missing -E and -q options to the built-in usage output.

PR: 275912

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But you should add something like "MFC after: 2 weeks" to your commit message. Also, though it's beyond the scope of this PR, I notice that the -q flag is ignored if neither the -e nor -E flag is used. That's inconsistent.

Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is
already documented in DESCRIPTION), and add the missing -E and -q
options to the built-in usage output.

PR:		275912
MFC after:	2 weeks
@llfw
Copy link
Contributor Author

llfw commented Dec 27, 2023

i added MFC after: 2 weeks. does that mean i should come back and submit new PRs for the MFCs, or will someone else handle that?

@asomers
Copy link
Member

asomers commented Dec 27, 2023

Whoever commits the PR will handle the MFC. You don't have commit access, right?

@llfw
Copy link
Contributor Author

llfw commented Dec 27, 2023

no, i don't. thanks!

freebsd-git pushed a commit that referenced this pull request Dec 27, 2023
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is
already documented in DESCRIPTION), and add the missing -E and -q
options to the built-in usage output.

PR:		275912
MFC after:	2 weeks
Pull Request:	#958
@asomers
Copy link
Member

asomers commented Dec 27, 2023

Fixed by 30ce26c .

@asomers asomers closed this Dec 27, 2023
@llfw llfw deleted the nfsstat-options-update branch December 27, 2023 19:13
freebsd-git pushed a commit that referenced this pull request Jan 19, 2024
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is
already documented in DESCRIPTION), and add the missing -E and -q
options to the built-in usage output.

PR:		275912
Pull Request:	#958

(cherry picked from commit 30ce26c)
freebsd-git pushed a commit that referenced this pull request Jan 20, 2024
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is
already documented in DESCRIPTION), and add the missing -E and -q
options to the built-in usage output.

PR:		275912
Pull Request:	#958

(cherry picked from commit 30ce26c)
@bsdimp bsdimp added the merged label Jan 29, 2024
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 13, 2024
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is
already documented in DESCRIPTION), and add the missing -E and -q
options to the built-in usage output.

PR:		275912
MFC after:	2 weeks
Pull Request:	freebsd/freebsd-src#958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants