-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nfsstat: update option strings in docs #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But you should add something like "MFC after: 2 weeks" to your commit message. Also, though it's beyond the scope of this PR, I notice that the -q flag is ignored if neither the -e nor -E flag is used. That's inconsistent.
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is already documented in DESCRIPTION), and add the missing -E and -q options to the built-in usage output. PR: 275912 MFC after: 2 weeks
4e22b20
to
3f78698
Compare
i added MFC after: 2 weeks. does that mean i should come back and submit new PRs for the MFCs, or will someone else handle that? |
Whoever commits the PR will handle the MFC. You don't have commit access, right? |
no, i don't. thanks! |
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is already documented in DESCRIPTION), and add the missing -E and -q options to the built-in usage output. PR: 275912 MFC after: 2 weeks Pull Request: #958
Fixed by 30ce26c . |
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is already documented in DESCRIPTION), and add the missing -E and -q options to the built-in usage output. PR: 275912 MFC after: 2 weeks Pull Request: freebsd/freebsd-src#958
Add the missing -q option to the nfsstat(1) manpage SYNOPSIS (it is already documented in DESCRIPTION), and add the missing -E and -q options to the built-in usage output.
PR: 275912