share/examples/sound/midi.c, share/examples/sound/ossmidi.h typo #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The name and email you provided in the comment are different from what's in https://patch-diff.githubusercontent.com/raw/freebsd/freebsd-src/pull/994.patch , which is your preference? |
|
Sorry about that, I prefer use the name and email below:
|
|
Ok, then please amend your commit ( In the bottom of the commit message. |
In line 52 of share/examples/sound/midi.c: CONTROLER_ON should be CONTROLLER_ON In line 68 of share/examples/sound/midi.c: CONTROLER_ON should be CONTROLLER_ON In line 36 of share/examples/sound/ossmidi.h: CONTROLER_ON should be CONTROLLER_ON Event: Advanced UNIX Programming Course (Fall’23) at NTHU.
Assume-Zhan
force-pushed
the
typo-controller
branch
from
31b0fcd
to
f14fc81
Compare
lwhsu
approved these changes
Jan 15, 2024
|
Merged as 0789c3b |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 13, 2024
Event: Advanced UNIX Programming Course (Fall’23) at NTHU. Pull Request: #994
5u623l20
pushed a commit
to 5u623l20/freebsd-src
that referenced
this pull request
Feb 16, 2024
Event: Advanced UNIX Programming Course (Fall’23) at NTHU. Pull Request: freebsd#994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in line 52 of share/examples/sound/midi.c: CONTROLER_ON -> CONTROLLER_ON
Typo in line 68 of share/examples/sound/midi.c: CONTROLER_ON -> CONTROLLER_ON
Typo in line 36 of share/examples/sound/ossmidi.h: CONTROLER_ON -> CONTROLLER_ON
Event: This is from the Advanced UNIX Programming Course (Fall’23) at NTHU.