Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/bin/pax/file_subs.c: typo #999

Closed
wants to merge 1 commit into from
Closed

/bin/pax/file_subs.c: typo #999

wants to merge 1 commit into from

Conversation

mnu1011
Copy link

@mnu1011 mnu1011 commented Jan 5, 2024

Line719: has -> have
(The auxiliary verb should be followed by the base form of the verb)

Event: Advanced UNIX Programming Course (Fall’23) at NTHU

@mnu1011 mnu1011 changed the title /bin/pax/file_subs.c: Fix grammar /bin/pax/file_subs.c: Fix typo Jan 5, 2024
@lwhsu
Copy link
Member

lwhsu commented Jan 5, 2024

Please note that your name is different from the From: (Author: in git) line, as you can see in https://patch-diff.githubusercontent.com/raw/freebsd/freebsd-src/pull/999.patch , note the space between in your last and first name. You don't have to specify them again in the pull request comment as what in commit object is sufficient and more import, as they will be recorded forever.

For a pull request, we don't need "merge commit" (the one with "Merge branch ...") and the duplicate commits (see above link, it contains two commits with the same change.) Please squash them and do a force push to update this PR. Also, you don't need to attach the patch file, as the commit itself is what we only need, it just takes unnecessary resource.

Finally, please change the last line:

This is from the Advanced UNIX Programming Course (Fall’23) at NTHU.

to

Event:    Advanced UNIX Programming Course (Fall’23) at NTHU.

@mnu1011 mnu1011 changed the title /bin/pax/file_subs.c: Fix typo /bin/pax/file_subs.c: typo Jan 7, 2024
(The auxiliary verb should be followed by the base form of the verb)

Name: HUNG-CHI CHANG
Email: s109062314s@gapp.nthu.edu.tw

Event: Advanced UNIX Programming Course (Fall’23) at NTHU
@mnu1011
Copy link
Author

mnu1011 commented Jan 7, 2024

Thank you for taking the time to respond. I have a couple of questions:

  1. when you mentioned that my name and the 'From: (Author: in git) line' are different, are you referring to the distinction between mnu1011 and HUNG-CHI CHANG? If so, it's because of Spec requirements, so I configured gitconfig to use my passport name. Otherwise, I prefer to use the name mnu1011.
  2. In pull request comments and commits, is there no need to explicitly mention Name and Email? Because commit metadata already includes this information?

As for the other issues you mentioned, I have already addressed them. If possible, please help me confirm. Thank you!

@lwhsu
Copy link
Member

lwhsu commented Jan 15, 2024

Thank you for taking the time to respond. I have a couple of questions:

1. when you mentioned that my name and the 'From: (Author: in git) line' are different, are you referring to the distinction between mnu1011 and HUNG-CHI CHANG? If so, it's because of Spec requirements, so I configured gitconfig to use my passport name. Otherwise, I prefer to use the name mnu1011.

2. In pull request comments and commits, is there no need to explicitly mention Name and Email? Because commit metadata already includes this information?

If that is the case, no need to mention the name and email in the commit message and we can accept your commit metadata.

freebsd-git pushed a commit that referenced this pull request Feb 13, 2024
Event:		Advanced UNIX Programming Course (Fall’23) at NTHU
Pull Request:	#999
@lwhsu
Copy link
Member

lwhsu commented Feb 13, 2024

Merged as 711a74e

@lwhsu lwhsu closed this Feb 13, 2024
5u623l20 pushed a commit to 5u623l20/freebsd-src that referenced this pull request Feb 16, 2024
Event:		Advanced UNIX Programming Course (Fall’23) at NTHU
Pull Request:	freebsd#999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants