Size mismatch in 1.3.4

[melvyn-sopacua]

Using:

diff --git a/libpkg/repo/binary/fetch.c b/libpkg/repo/binary/fetch.c
index 6555512..e2aa789 100644
--- a/libpkg/repo/binary/fetch.c
+++ b/libpkg/repo/binary/fetch.c
@@ -221,8 +221,8 @@ checksum:

            unlink(dest);
            pkg_emit_error("cached package %s-%s: "
-                   "size mismatch, fetching from remote",
-                   name, version);
+                   "size mismatch (%li != %li), fetching from remote",
+                   name, version, pkgsize,st.st_size);
            return (pkg_repo_binary_try_fetch(repo, pkg, true, mirror, destdir));
    }
    retcode = sha256_file(dest, cksum);

The output is:
pkg: cached package vim-7.4.364: size mismatch (4901580 != 4904224), fetching from remote

4904224 is the correct pkgsize. I have no idea where the 4901580 comes from. The packagesite.txz in the repo also has the correct 4904224 as pkgsize. No 4901580 in packagesite.yaml anywhere.

[melvyn-sopacua]

Workaround:
delete/move /var/db/pkg/repo-yourrepo.sqlite (and I did the repo.meta also). The wrong sizes are now gone and everything works again. If you need the faulty files, I have kept them.

[vstakhov]

I think I've fixed this problem in the master branch in 74f4ebe commit.

[melvyn-sopacua]

Looks solid. I wanted to make a regression test for this bug but I see that the testing framework has been not working for some time. With all the regressions, some of which caught minutes after release, it's perhaps an idea to reinstate it or go with a new framework?

[bapt]

All help in that area to get regression working is really welcomed :)

2014-08-05 4:04 GMT+02:00 Melvyn Sopacua notifications@github.com:

Looks solid. I wanted to make a regression test for this bug but I see
that the testing framework has been not working for some time. With all the
regressions, some of which caught minutes after release, it's perhaps an
idea to reinstate it or go with a new framework?

—
Reply to this email directly or view it on GitHub
#906 (comment).

[melvyn-sopacua]

Ok, can you elaborate what's broken now? I see several things in there (bsd.tests.mk and configure.ac hooks) and without some architectural overview it's quite the puzzle to even figure out how to trigger the broken implementation.

[bdrewery]

This is not fixed. I ran pkg update -f on 1.3.5.1+ (git), and just ran pkg install -f git and got:

pkg: cached package git-2.0.2: size mismatch, fetching from remote
Fetching git-2.0.2.txz: 100% of 3 MB
pkg: cached package git-2.0.2: size mismatch, cannot continue

[bdrewery]

This was the whole purpose of the cached filenames. What happened??

[bdrewery]

checksum filenames*