Add basic support for upgrading ports with flavors. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoding the flavor in the origin substantially dedups the various internal lookups, and most places that try to actually go to the dir to do stuff already use portdir() to find dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't touch the fresh-install cases or the using-packages case, and those haven't been tested. I believe the package case doesn't care much about origins; it just goes by package name, and the new install case can set flavors with
-mlike currently anyway. My guess is that it won't affect them.So, I think this is a solid step forward by itself. Upgrading installed ports via ports is presumably the 99.99% usecase for portupgrade, and this should make flavors work for that.