[feature request] Generate pkg-plist or pkg-plist diff during testport.

[davidchisnall]

Poudriere can tell me what changes I need to make to my pkg-plist file, but the output is not in any machine-readable form. I'd estimate that around 20-30% of the time that I spend on updating a port is manually going and doing what poudiere tells me to do to fix the output. Having it spit out a diff that I could review and apply to fix the port would dramatically improve productivity (not having the pkg-plist file at all would be even better, but that's not a poudriere issue).

[mat813]

I wanted to open this issue for so long, even simply having the new plist saved in /tmp/new-plist in the jail would allow to simply do something like this:

vim -d /usr/local/poudriere/data/.m/*/ref/tmp/new-plist pkg-plist

[bdrewery]

Spitting out a diff implies the output is 100% correct. If that were the case then why not use automatic plists? (Portmgr decided against it.)
I like @mat813's idea but it should save to the logs dir probably like portlint output does.

[davidchisnall]

Spitting out a diff implies the output is 100% correct.

I don't understand this argument. It's already telling me the changes that I probably need to make, it's just wasting my time making them harder to apply. With a diff, given a constant amount of my time to work on ports, I can spend more time checking the contents of the diff and less time on manually turning the diff into something I can apply.

If that were the case then why not use automatic plists? (Portmgr decided against it.)

Why not use automatic plists for any port that doesn't want to explicitly exclude things created by the install step? Again, making port maintainers do trivially automatable work doesn't really help in keeping the ports tree well maintained.

[bdrewery]

For the record I support something like AUTO_PLIST but gave up on that argument in Ports. I just don't like the idea of a diff here. I'm all for generating the plist and saving it with the logs and making it easily accessible.

[bdrewery]

Also similar to #641 we may be lacking a hook here for this and should support it.