Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIM: ArchSpace - Inconsistent computed Vertical Area #14687

Closed
2 tasks done
marcuspollio opened this issue Jun 15, 2024 · 2 comments
Closed
2 tasks done

BIM: ArchSpace - Inconsistent computed Vertical Area #14687

marcuspollio opened this issue Jun 15, 2024 · 2 comments
Labels
Bug This issue or PR is related to a bug WB BIM Related to the BIM/Arch Workbench

Comments

@marcuspollio
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

In the BIM Workbench, the ArchSpace provides several computed values from its geometry, such as the horizontal area, the perimeter length (both now, with 2 methods), and also the Vertical Area.
However, this third computed value is not always correct. For vertical extrusions (prismatic spaces based on a flat XY profile), there are no issues. But when ArchSpaces have inclined faces or curved features, the Vertical Area provided can be wrong or misleading.

In the example below, the first Space ("Trapezoid") has two inclined faces which are not computed in the Vertical Area. These two inclined faces are not really vertical indeed, so one could say it's correct.
The third and fourth Spaces ("Barrel_Vault" and "Sphere") have curved features, which are not vertical either.
Yet they are included in the calculation of the Vertical Area.

For consistency sake, one would expect that either all strictly vertical-only areas are computed, or all non-horizontal areas are computed. The latter would cover a wider range of situations. This is open to debate, of course =D

FC_Space

Full version info

OS: GNU/Linux Ubuntu 22.04 LTS (DE:GNOME/pop)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37730 (Git)
Build type: Release
Branch: main
Hash: 30f7f2688921e6e5242beaa9d71e0fdd844b20e3
Python 3.10.12, Qt 5.15.3, Coin 4.0.0, Vtk , OCC 7.6.3

Subproject(s) affected?

BIM/Arch

Anything else?

BIMSpace.zip

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added Bug This issue or PR is related to a bug WB BIM Related to the BIM/Arch Workbench labels Jun 15, 2024
@DeniseBryson
Copy link
Contributor

Hi,
I can try to correct this as well. :) In my opinion vertical areas should only count vertical areas, otherwise we should call it non horizontal areas? Any other ideas?

@yorikvanhavre
Copy link
Member

Closing as solved by #14761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug WB BIM Related to the BIM/Arch Workbench
Projects
None yet
Development

No branches or pull requests

4 participants