Good neighbour #166
Merged
Good neighbour #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users, especially developers, may install freeciv-web alongside other tomcat webapps. Be nice and don't hoard ROOT.
If so configured, use tomcat-manager to stop just freeciv-web and not the whole tomcat server.
nginx.conf is an installation file, under the responsibility of the site admin. The default upstream content already supports loading of several virtual servers or apps defined under sites-enabled, so use that instead of greedy full control. Some more work may still be needed to really share nginx with other apps, like declaring a server name or wrapping everything in a freeciv-web specific location.
When stopping freeciv-web, remove it from sites-enabled and tell nginx to reload its configuration, instead of stopping all of nginx.
Installing freeciv-web doesn't overwrite nginx and tomcat config anymore.
|
looks good. please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be nice and don't overwrite tomcat and nginx system configuration, and don't kill them when stopping freeciv-web.