Add highways to trident and hex2t tilesets #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new files need to be added to tarball distribution and get installed too. This need to be done for both legacy autotools and new meson based build system. Former requires changes to relevant Makefile.am, and latter to meson.build. |
petervdmeer
force-pushed
the
artwork/trident_highways
branch
from
7519f36
to
c1a391a
Compare
The highways are added at a 3 to 4 pixels offset to railroads, this allows both to be visible on the same tile, while still allowing them to connect as well. (Depending on if the ruleset wants those roads to connect or be separate.)
petervdmeer
force-pushed
the
artwork/trident_highways
branch
from
c1a391a
to
f3233a5
Compare
|
Files are added to the meson.build and Makefile.am files. I've tested 'ninja' and 'ninja install' and the new files ended up in the (custom) install directory for Meson. I've also tested 'make' and 'make install'. The new files also ended up in the (other custom) install directory. |
|
Ticket to handle this: https://redmine.freeciv.org/issues/255 |
|
Merged outside github UI. |
alien-valkyrie
pushed a commit
to alien-valkyrie/freeciv
that referenced
this pull request
Apr 11, 2024
See RM freeciv#61 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
alien-valkyrie
pushed a commit
to alien-valkyrie/freeciv
that referenced
this pull request
Apr 11, 2024
See RM freeciv#61 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
alien-valkyrie
pushed a commit
to alien-valkyrie/freeciv
that referenced
this pull request
Apr 15, 2024
See RM freeciv#61 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highways are added at a 3 to 4 pixels offset to railroads, this allows both to be visible on the same tile, while still allowing them to connect as well. (Depending on if the ruleset wants those roads to connect or be separate.)