Incorrect error thrown when function is in comments

[Bouncey]

Pre-Submission Checklist

• Your pull request targets the staging branch of FreeCodeCamp.
• Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
• You have only one commit (if not, squash them into one commit).
• All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

• Small bug fix (non-breaking change which fixes an issue)

Checklist:

• Tested changes locally.
• Closes currently open issue (replace XXXX with an issue no): Closes Doesn't see my comments #10925

Description

Added new regExp in detect-unsafe-code-stream.js to detect if the word function is in comments and if so, ignore and do not throw the error SyntaxError: Unsafe or unfinished function declaration

[ktajpuri]

@Bouncey could you please explain the regex you used? A bit tough to figure out for me.

[Bouncey]

cc @FreeCodeCamp/issue-moderators - this is ready

[ltegman]

This looks good to me, but I can't get the branch up and running locally for some reason. Would love a confirmation from someone who can get it running that this works as it should.

[ghost]

@ltegman, I will test this in a few hours 👍

[ghost]

Having issue with the tests on my local setup. Don't believe it's an issue with this PR however.

cc/ @FreeCodeCamp/issue-moderators, please try and review this PR!

[Bouncey]

Unable to QA due to #11198

[ltegman]

Something about the state of staging when you made your changes is what was causing problems for me. I rebased this branch against the latest staging and was able to QA just fine. LGTM 👍

[BerkeleyTrue]

@FreeCodeCamp/issue-moderators

When merging a PR please ensure the PR actually works or does what it says. This file is no longer used anywhere and does not run actually run anywhere.

[ltegman]

Huh. I compared this code side by side with code that didn't have the change and saw an improvement, but it must have been something else doing it. Sorry about that!