Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Data Visualization with D3: Change Styles Based on Data: … #12700

Merged
merged 1 commit into from
Jan 21, 2017
Merged

Fix typo in Data Visualization with D3: Change Styles Based on Data: … #12700

merged 1 commit into from
Jan 21, 2017

Conversation

petercollingridge
Copy link
Contributor

Change h1 to h2.

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 21, 2017
systimotic
systimotic approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member

@systimotic systimotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🎈

Nice work, thank you for reporting this issue and fixing it!

@systimotic systimotic merged commit 81eba79 into freeCodeCamp:staging Jan 21, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 21, 2017
@petercollingridge petercollingridge deleted the fix/d3-change-styles-typo branch January 21, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systimotic systimotic systimotic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petercollingridge @systimotic @BerkeleyTrue