Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(challenge): Stricter tests for "OOP: Constructor property" #13129

Merged
merged 1 commit into from
Feb 4, 2017
Merged

fix(challenge): Stricter tests for "OOP: Constructor property" #13129

merged 1 commit into from
Feb 4, 2017

Conversation

Greenheart
Copy link
Member

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

  • Added a test case to ensure campers use Object.constructor rather than the instanceof operator.
  • Also fixed an misleading sentence in the instruction.

Ref: #12966 (comment)

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 4, 2017
@no-stack-dub-sack
Copy link
Member

no-stack-dub-sack commented Feb 4, 2017

EDIT: still LGTM, but after looking more closely, I have one minor suggestion 👇

Copy link
Member

@no-stack-dub-sack no-stack-dub-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the changes locally and they work fine! However, I think we should also make the instructions a tad more clear, just to eliminate any possible confusion:

"Write a joinDogFraternity function that takes a candidate parameter and, using the constructor property, return true if the candidate is a Dog, otherwise return false."

Who knows, this may not be necessary, but I don't think it could hurt.

Thoughts @Greenheart?

@Greenheart
Copy link
Member Author

@no-stack-dub-sack I like it, will add that right away! 😄

* Also fixed an misleading sentence in the instruction.
@no-stack-dub-sack no-stack-dub-sack merged commit 3564626 into freeCodeCamp:staging Feb 4, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 4, 2017
@Greenheart Greenheart deleted the fix/oop-constructor-property branch February 4, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants