Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Fahrenheit Variable Below Comment Line #15670

Merged
merged 3 commits into from
Aug 1, 2017
Merged

Move Fahrenheit Variable Below Comment Line #15670

merged 3 commits into from
Aug 1, 2017

Conversation

prateekgoel
Copy link
Contributor

@prateekgoel prateekgoel commented Jul 20, 2017 •
edited

Challenge URL: https://www.freecodecamp.org/challenges/convert-celsius-to-fahrenheit

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Changed the desciption as mentioned in the linked issue.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 20, 2017
@dhcodes
Copy link
Contributor

dhcodes commented Jul 28, 2017

@prateekgoel could you also add Eric's note from the issue thread? You can go back to your branch, add the note, save the file, and then run git add ., git commit --amend, save the file as-is, and then run git push origin fix/move-fahrenheit-variable -f to update this PR.

@dhcodes dhcodes self-requested a review July 28, 2017 14:20
dhcodes
dhcodes suggested changes Jul 28, 2017
View reviewed changes
seed/challenges/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting.json Outdated
@@ -104,7 +104,7 @@
"title": "Convert Celsius to Fahrenheit",
"description": [
"The algorithm to convert from Celsius to Fahrenheit is the temperature in Celsius times <code>9/5</code>, plus <code>32</code>.",
"You are given a variable <code>celsius</code> representing a temperature in Celsius. Use the variable <code>fahrenheit</code> already defined and apply the algorithm to assign it the corresponding temperature in Fahrenheit."
"You are given a variable <code>celsius</code> representing a temperature in Celsius. Use the variable <code>fahrenheit</code> already defined and assign it the Fahrenheit temperature equivalent to the given Celsius temperature. Use the algorithm mentioned above to help convert the Celsius temperature to Fahrenheit."

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@dhcodes dhcodes added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jul 31, 2017
@camperbot
Copy link
Contributor

@prateekgoel updated the pull request.

@camperbot
Copy link
Contributor

@prateekgoel updated the pull request.

@prateekgoel
Copy link
Contributor Author

prateekgoel commented Aug 1, 2017 •
edited

@dhcodes Added the note.

@dhcodes dhcodes merged commit f92294b into freeCodeCamp:staging Aug 1, 2017
@BerkeleyTrue BerkeleyTrue removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Aug 1, 2017
@dhcodes
Copy link
Contributor

dhcodes commented Aug 1, 2017

@prateekgoel I forgot to mention this, but in the future, please squash your commits. Read about it here: https://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231

Alternatively, you could amend your past changes and then force push as I explained in the comment above. This would've kept these changes as one commit.

@prateekgoel
Copy link
Contributor Author

prateekgoel commented Aug 1, 2017 •
edited

@dhcodes Sure. I'll take care in future. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhcodes dhcodes dhcodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prateekgoel @dhcodes @camperbot @BerkeleyTrue