Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Add react-freecodecamp-search to Nav #16209

Merged

Conversation

Bouncey
Copy link
Member

@Bouncey Bouncey commented Dec 18, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16166

Description

Search all the things!

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 18, 2017
@QuincyLarson
Copy link
Contributor

QuincyLarson commented Dec 18, 2017

@Bouncey OK - I just tested this locally. It looks great. I have some feedback for how it can be even more intuitive:

  1. Drop the description and just show the title - this will be less overwhelming.
  2. Suppress stubs from search results. Clicking through to a stub will be a negative user experience.
  3. Group similar types of results. For example, Have a single header "Lesson" with the titles below it, then "Blog Articles" or "Guide Articles" or "Videos". Is it possible to highlight the matching part? Note that here I mistyped "trst", so it's highlighting "test" to show that this is how it's matching. This is subtle, but if it's possible, we should do something like this for usability purposes.
    react_-_a_javascript_library_for_building_user_interfaces
  4. Make the text area completely white (#ffffff) instead of gray so it matches the rest of our UI elements
  5. Add an magnifying glass symbol inside the search box (font awesome should have a good one) and color it Return Largest Numbers in Arrays - Not Recognizing Correct Answer #6400

@Bouncey
Copy link
Member Author

Bouncey commented Dec 18, 2017

So drop the description in favour of an extract that shows the match?

All styling and displaying of results in the dropdown is the responsibility of the freecodecamp/react-freecodecamp-search repo.

Suppressing stubs will be at the elasticsearch end of the process, freecodecamp/search

@QuincyLarson
Copy link
Contributor

@Bouncey Yes - I think just showing say, the sentence that contains the match - would be fine. We can do this on the Search repo, but I think we can do these styling changes here on this PR first before we merge this.

@Bouncey
Copy link
Member Author

Bouncey commented Dec 18, 2017

Yes, I would need to update styles in the package, then update this PR with the next release

@QuincyLarson
Copy link
Contributor

@Bouncey OK - I'm going to go ahead and merge this and we can open another PR to address it next.

@QuincyLarson QuincyLarson merged commit b4542a5 into freeCodeCamp:staging Dec 18, 2017
@QuincyLarson QuincyLarson removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 18, 2017
QuincyLarson added a commit that referenced this pull request Dec 18, 2017
@Bouncey Bouncey deleted the feat/react-freecodecamp-search branch December 18, 2017 21:13
@raisedadead
Copy link
Member

@QuincyLarson @Bouncey Was this reverted? If so, was it handled by something else? In either case the linked issue should have been either re-opened or any other PR which handled this should have been linked.

@Bouncey
Copy link
Member Author

Bouncey commented Jan 5, 2018

@raisedadead I don't understand what you mean? I'm not aware of this being reverted.

@raisedadead
Copy link
Member

See 8485041

mhatout pushed a commit to mhatout/freeCodeCamp that referenced this pull request Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants