-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search): Add react-freecodecamp-search to Nav #16209
feat(search): Add react-freecodecamp-search to Nav #16209
Conversation
@Bouncey OK - I just tested this locally. It looks great. I have some feedback for how it can be even more intuitive:
|
So drop the description in favour of an extract that shows the match? All styling and displaying of results in the dropdown is the responsibility of the freecodecamp/react-freecodecamp-search repo. Suppressing stubs will be at the elasticsearch end of the process, freecodecamp/search |
@Bouncey Yes - I think just showing say, the sentence that contains the match - would be fine. We can do this on the Search repo, but I think we can do these styling changes here on this PR first before we merge this. |
Yes, I would need to update styles in the package, then update this PR with the next release |
@Bouncey OK - I'm going to go ahead and merge this and we can open another PR to address it next. |
This reverts commit b4542a5.
@QuincyLarson @Bouncey Was this reverted? If so, was it handled by something else? In either case the linked issue should have been either re-opened or any other PR which handled this should have been linked. |
@raisedadead I don't understand what you mean? I'm not aware of this being reverted. |
See 8485041 |
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #16166
Description
Search all the things!