New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(map): Removed NA text for challenge without time estimat #16479
fix(map): Removed NA text for challenge without time estimat #16479
Conversation
@lgrzybowski Next time please comment on the issue you're working on so that the other participants know that you're on it. |
The if/else block added in Block.jsx produces a lot of duplicate code. Perhaps there's a more elegant way to inject the time span. {
time
? <span className={ `${ns}-block-time` }>({ time })</span>
: ''
} |
Or you could just leave the time as N/A and test for it in the JSX and then it's a one line change to one file only.
|
@lgrzybowski updated the pull request. |
@0x0936 This should looks better now. |
common/app/Map/Block.jsx
Outdated
{ | ||
time | ||
? <span className={ `${ns}-block-time` }>({ time })</span> | ||
: '' |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@lgrzybowski updated the pull request. |
@BerkeleyTrue Thx for your review this should be looking better now. |
@lgrzybowski nice work! Happy Coding |
@lgrzybowski Awesome! Thank you for your contribution to the codebase! |
…to_blank_when_no_estimation fix(map): Removed NA text for challenge without time estimat
Closes #16454
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #16454
Description
I had run already implemented tests, but I think for react project it would be really nice to use jest with snapshot testing. One more idea would be to add eslint check as part of
npm test
command