-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(seed): Adds the json file for css grid challenges #16837
feat(seed): Adds the json file for css grid challenges #16837
Conversation
order or json files changed and new css grid challenges json is added
@QuincyLarson @moT01. feedback from the previous PR was implemented in this PR. |
@ahmadabdolsaheb awesome! Thanks for implementing this and opening the pull request. @mstellaluna would you be interested in QA'ing this? I think it's a good fit for you. |
@QuincyLarson Sure, I will gladly QA it. |
I am done testing them. Great job!! |
@mstellaluna I think that's one of the flex challenges - And not part of this PR? |
@mstellaluna Thanks for the QA and the feedback. |
@moT01 yea true hold on something not right.... |
Hi @mstellaluna this LGTM, can you hit the approve button and give this a merge, if all is OK? |
@raisedadead I had only one suggestion to this set of challenges |
otherwise there were no issues, was a great set of challenges |
@raisedadead i'll approve and merge and open a separate issue for the visual. it's something minor that shouldn't be holding this up at all.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
@ahmadabdolsaheb @moT01 well done my friends! Thanks to @raisedadead and @mstellaluna for QA'ing this! |
…s-grid-chall-one feat(seed): Adds the json file for css grid challenges
order or json files changed and new css grid challenges json is added
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #16368
Description
Added 22 CSS Grid challenges in a JSON file and change the order of the responsive-web-design-projects.json so the Grid challenges could be numbered properly.