Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seed): Adds the json file for css grid challenges #16837

Merged
merged 1 commit into from
Mar 8, 2018
Merged

feat(seed): Adds the json file for css grid challenges #16837

merged 1 commit into from
Mar 8, 2018

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Mar 5, 2018

order or json files changed and new css grid challenges json is added

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16368

Description

Added 22 CSS Grid challenges in a JSON file and change the order of the responsive-web-design-projects.json so the Grid challenges could be numbered properly.

order or json files changed and new css grid challenges json is added
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 5, 2018
@ahmaxed
Copy link
Member Author

ahmaxed commented Mar 5, 2018

@QuincyLarson @moT01. feedback from the previous PR was implemented in this PR.

@QuincyLarson
Copy link
Contributor

@ahmadabdolsaheb awesome! Thanks for implementing this and opening the pull request.

@mstellaluna would you be interested in QA'ing this? I think it's a good fit for you.

@mstellaluna
Copy link
Member

@QuincyLarson Sure, I will gladly QA it.

@mstellaluna
Copy link
Member

mstellaluna commented Mar 6, 2018

I am done testing them. Great job!!
this is the only issue I found.
#16839
@QuincyLarson @ahmadabdolsaheb @raisedadead

@moT01
Copy link
Member

moT01 commented Mar 6, 2018

@mstellaluna I think that's one of the flex challenges - And not part of this PR?

@ahmaxed
Copy link
Member Author

ahmaxed commented Mar 6, 2018

@mstellaluna Thanks for the QA and the feedback.

@mstellaluna
Copy link
Member

@moT01 yea true hold on something not right....

@raisedadead
Copy link
Member

Hi @mstellaluna this LGTM, can you hit the approve button and give this a merge, if all is OK?

@mstellaluna
Copy link
Member

@raisedadead I had only one suggestion to this set of challenges
and it was for "Use grid-column to control spacing" specifically
my suggestion is to add a link to a visual aide as to what the lines are referring to since we don't see the grid lines in the preview

@mstellaluna
Copy link
Member

otherwise there were no issues, was a great set of challenges

@mstellaluna
Copy link
Member

@raisedadead i'll approve and merge and open a separate issue for the visual. it's something minor that shouldn't be holding this up at all..

Copy link
Member

@mstellaluna mstellaluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@mstellaluna mstellaluna merged commit 92ebf9f into freeCodeCamp:staging Mar 8, 2018
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 8, 2018
@QuincyLarson
Copy link
Contributor

@ahmadabdolsaheb @moT01 well done my friends!

Thanks to @raisedadead and @mstellaluna for QA'ing this!

@ahmaxed ahmaxed deleted the feature/css-grid-chall-one branch March 8, 2018 06:23
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this pull request Oct 12, 2018
…s-grid-chall-one

feat(seed): Adds the json file for css grid challenges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants