Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore case in HTML/CSS hex color waypoints. #1832

Merged
merged 1 commit into from Aug 17, 2015
Merged

Ignore case in HTML/CSS hex color waypoints. #1832

merged 1 commit into from Aug 17, 2015

Conversation

ahstro
Copy link
Member

@ahstro ahstro commented Aug 17, 2015

Just added the ignore case flag to the hex-matching regex.

Fixes #1830

@dcsan dcsan added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 17, 2015
@ahstro
Copy link
Member Author

ahstro commented Aug 17, 2015

Also, #00[Ff]{2}00/g should probably be changed to #00FF00/ig to conform with the rest of the regexes.

benmcmahon100 added a commit that referenced this pull request Aug 17, 2015
@benmcmahon100
Merge pull request #1832 from ahstro/ahstro-1830
cffefac 
Ignore case in HTML/CSS hex color waypoints.
@benmcmahon100 benmcmahon100 merged commit cffefac into freeCodeCamp:staging Aug 17, 2015
@benmcmahon100 benmcmahon100 removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 17, 2015
@ahstro ahstro deleted the ahstro-1830 branch August 17, 2015 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahstro @dcsan @benmcmahon100