Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text capitalization #18343

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Update text capitalization #18343

merged 1 commit into from
Oct 12, 2018

Conversation

dvdrip
Copy link

@dvdrip dvdrip commented Oct 12, 2018

Description

Pre-Submission Checklist

Common mandatory requirements

  • This pull request targets the master branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/
    (e.g. fix/signin-issue)
  • Reviewed necessary guidelines in CONTRIBUTING.md.

By submitting this pull request, I have verified the following:

  • Added descriptive name to pull request. (mandatory)

    Your PR should NOT be called Update index.md, since it does not help the maintainer understand what has been changed.

    Good Guide PR title examples:

    fix(guide): Git - edit Git Commit article
    feat(guide): PHP - create PHP section and add Data Structures article

    Good Coding challenge PR title examples:

    fix(coding): add tests to Basic HTML challenge
    fix(coding): update instructions to CSS Grid challenge

    Good Learning platform PR title examples:

    fix(platform): fixed sign in api
    fix(platform): removed css from editor

Issues Closures

  • Addressed currently open issue. (replace XXXXX with an issue no in next line)

Closes #XXXXX

Since this change is a copy edit or translation for Guide articles or Coding Challenges:

  • I confirm no plagiarized, duplicate, or repetitive content that has been directly copied from another source.
  • I am adding only https links to external sources.
  • I am not adding short links instead of full URLs to webpages.
  • I have followed the recomended style guides for the copy edit.

Requirements, for changes which are NOT simple copy editing or translations:

You may skip the below ONLY if your changes do not touch tests, ui logic, api-server, etc. Your PR may not be accepted, if you did not meet these mandatory requirements. Simply put, we can't assume it will work if we never saw it working.

Since this change adds, updates or removes coding challenge tests:

  • I completed the coding challenge locally, and the changes look good.
  • Other tests or user stories in instructions are not affected.

Since this change is for the Learning platform (UI, logic, etc.):

  • I confirm my changes look good by running freeCodeCamp locally.
  • All new and existing tests pass the command npm test.

(Optional) Additional Context and Screenshots:

@honmanyau honmanyau merged commit b0b38c8 into freeCodeCamp:master Oct 12, 2018
@honmanyau
Copy link
Member

@dvdcorgi Thank you very much for submitting a pull request (PR). I think this one is okay and can be merged because title case is preferred. In the future, please keep in mind that minor formatting/grammatical changes can be combined into a single PR because it makes things a bit easier for maintainers and contributors!

In any case, congratulations on having your first PR accepted here. ☀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants