Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BASH books #18829

Merged
merged 3 commits into from Oct 15, 2018
Merged

Added BASH books #18829

merged 3 commits into from Oct 15, 2018

Conversation

amitech
Copy link
Contributor

@amitech amitech commented Oct 13, 2018

Added links of BASH and unix programming books

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

Added links of BASH and unix programming books
@lynxlynxlynx
Copy link
Member

Looks ok, but adding readable link text would improve it. Check the previous entries.

@amitech
Copy link
Contributor Author

amitech commented Oct 13, 2018

@lynxlynxlynx thanks, I made suggested changes.

@lynxlynxlynx
Copy link
Member

lynxlynxlynx commented Oct 13, 2018

But why Amazon Smile, when you had them on Amazon (and one link still points there)? Just be consistent.

@amitech
Copy link
Contributor Author

amitech commented Oct 13, 2018

Corrected it now. Thanks.

@lynxlynxlynx
Copy link
Member

LGTM

@camperbot camperbot removed their request for review October 13, 2018 17:58
@QuincyLarson QuincyLarson merged commit 5f244a6 into freeCodeCamp:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants