Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redaction and translation updated. #19761

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Conversation

Josev47
Copy link
Contributor

@Josev47 Josev47 commented Oct 18, 2018

Enhanced redaction and translation, made a better explanation to enhance the understanding about the description, the instructions, the tests and the challenge seed.

  • [ x ] I have read freeCodeCamp's contribution guidelines.
  • [ x ] My pull request has a descriptive title (not a vague title like Update index.md)
  • [ x ] My pull request targets the master branch of freeCodeCamp.
  • [ x ] None of my changes are plagiarized from another source without proper attribution.
  • [ x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

Enhanced redaction and translation, made a better explanation to enhance the understanding about the description, the instructions, the tests and the challenge seed.
@moT01 moT01 added language: Spanish scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Oct 23, 2018
@@ -42,7 +42,7 @@ tests:
}
</style>

<h2>CatPhotoApp</h2>
<h2 class="red-text">CatPhotoApp</h2>

This comment was marked as off-topic.

@RandellDawson RandellDawson added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Feb 14, 2019
@RandellDawson
Copy link
Member

@raisedadead It appears this PR is attempting to add more content to this challenge, instead of just a direct translation of the challenge.

I believe we need to have new additions only come from the English version first and then we create translations (automatically using the bot) and also auto-create PRs for each language which would go through the normal PR review process.

If I am mistaken, please let me know.

@lynxlynxlynx
Copy link
Member

There's no new content here, just the common mistake of adding the solution to the seed.

@RandellDawson RandellDawson removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Feb 14, 2019
@RandellDawson
Copy link
Member

@lynxlynxlynx Sorry about that. It appeared there was additions to the description section, but it appears those were just translations. I think I may have mixed this one up with another PR.

@raisedadead raisedadead added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Feb 15, 2019
@lynxlynxlynx lynxlynxlynx merged commit 21363e9 into freeCodeCamp:master Mar 13, 2019
@lynxlynxlynx
Copy link
Member

Thanks, I've fixed the remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: merge conflict To be applied to PR's that have a merge conflict and need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants