Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a third way of commenting - JSDoc style #20353

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

VisheshSingh
Copy link
Contributor

@VisheshSingh VisheshSingh commented Oct 18, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@moT01 moT01 merged commit 8f96524 into freeCodeCamp:master Oct 29, 2018
@moT01
Copy link
Member

moT01 commented Oct 29, 2018

You forgot to close your code block by adding the three ticks(`) at the bottom of your code @VisheshSingh - don't worry about it, I'm just going to merge this and give the article some touch up as there's some other things that could be fixed - Congratulations on your first contribution to freeCodeCamp!

@VisheshSingh
Copy link
Contributor Author

Thanks a lot! Yay!!!!

matthew-beaty pushed a commit to matthew-beaty/freeCodeCamp that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants