Remove ternary operator in React component #23248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed and re-opened to resolve Travis errors! |
honmanyau
added
the
status: waiting triage
|
@QuincyLarson I think the refactoring is okay to be merged, but the PR targets a "core" file and we're not sure if we should just merge it! Thank you very much for having a look at this! |
honmanyau
removed
the
status: waiting triage
|
@honmanyau Agreed - I'm going to let @Bouncey take a look at it. |
cmccormack
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
FWIW, this looks fine to me. Render can be either a Boolean or null (source) when you want to render a component conditionally. This is currently a common pattern with React
Remove ternary operator in React component, unnecessary operator to render null
raisedadead
added
the
platform: learn
Bouncey
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ternary operator in React component, unnecessary operator to render null
Update index.md)masterbranch of freeCodeCamp.If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX