Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further explanation of What vs How #24135

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Further explanation of What vs How #24135

merged 2 commits into from
Mar 15, 2019

Conversation

SQrL143
Copy link
Contributor

@SQrL143 SQrL143 commented Oct 20, 2018 •
edited

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@SQrL143
Copy link
Contributor Author

SQrL143 commented Oct 20, 2018

Marked my checklist

@huyenltnguyen huyenltnguyen added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Dec 23, 2018
@Manish-Giri Manish-Giri removed the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Mar 15, 2019
Manish-Giri
Manish-Giri approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@Manish-Giri Manish-Giri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DaddyBA

Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍 We're happy to accept these changes and look forward to future contributions. 📝

@Manish-Giri Manish-Giri merged commit f1360f1 into freeCodeCamp:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manish-Giri Manish-Giri Manish-Giri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SQrL143 @Manish-Giri @camperbot @huyenltnguyen