Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #26557

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Typo #26557

merged 1 commit into from
Oct 24, 2018

Conversation

LadyTano
Copy link
Contributor

@LadyTano LadyTano commented Oct 23, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@LadyTano LadyTano closed this Oct 23, 2018
@scissorsneedfoodtoo
Copy link
Contributor

@LadyTano, great catch here! This seems like a meaningful change. Any reason why you decided to close this PR?

@scissorsneedfoodtoo scissorsneedfoodtoo self-assigned this Oct 23, 2018
@scissorsneedfoodtoo scissorsneedfoodtoo merged commit bf171cc into freeCodeCamp:master Oct 24, 2018
@scissorsneedfoodtoo
Copy link
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

@LadyTano, everything LGTM! Thank you for helping us improve this section of the guide. Looking forward to your next contribution! 👍 👍

Hope you don't mind that I reopened your PR and merged it. Just seemed like a waste to let a fix like this remain closed.

vdkhadke pushed a commit to vdkhadke/freeCodeCamp that referenced this pull request Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants