Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed position data to make correct values pass #26987

Merged
merged 1 commit into from
Feb 2, 2019
Merged

changed position data to make correct values pass #26987

merged 1 commit into from
Feb 2, 2019

Conversation

tannerabread
Copy link
Contributor

changed the y data point in the third nested array to a 9 so that the test cannot be passed by finding the highest y value
reference to issue #17996

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #17996

@tannerabread
changed position data to make correct values pass
6c05959 
changed the y data point in the third nested array to a 9 so that the test cannot be passed by finding the highest y value
reference to issue freeCodeCamp#17996
@camperbot camperbot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: need to test locally labels Nov 13, 2018
@RandellDawson RandellDawson reopened this Nov 25, 2018
@RandellDawson
Copy link
Member

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

cmccormack
cmccormack approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@cmccormack cmccormack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch and the fix looks good to me 👍. Thank you for your contribution!

Nirajn2311
Nirajn2311 approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Nirajn2311 Nirajn2311 merged commit a3c917e into freeCodeCamp:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccormack cmccormack cmccormack approved these changes

@Nirajn2311 Nirajn2311 Nirajn2311 approved these changes

@RandellDawson RandellDawson Awaiting requested review from RandellDawson

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
5 participants
@tannerabread @RandellDawson @cmccormack @Nirajn2311 @camperbot