Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint use spans for inline elements reverts to previous waypoint styling #3089

Closed
duffn opened this issue Sep 5, 2015 · 4 comments
Closed

Comments

@duffn
Copy link
Contributor

duffn commented Sep 5, 2015

Challenge http://freecodecamp.com/challenges/waypoint-use-spans-for-inline-elements has an issue.

This waypoint reverts back to a previous waypoint styling.

  • It still contains the smaller-image class on the https://bit.ly/fcc-relaxing-cat image, though the class was removed and replace with img-responsive in the previous waypoint.
  • It contains the dead link Click here for cat photos.
  • The h2 heading still contains the red-text class.
<h2 class="red-text text-center">CatPhotoApp</h2>

<p>Click here for <a href="#">cat photos</a>.</p>
<a href="#"><img class="smaller-image thick-green-border" src="https://bit.ly/fcc-relaxing-cat"></a>

screen shot 2015-09-05 at 8 23 29 am

It should be

<h2 class="text-primary text-center">CatPhotoApp</h2>
<a href="#"><img class="img-responsive thick-green-border" src="https://bit.ly/fcc-relaxing-cat"></a>

screen shot 2015-09-05 at 8 28 51 am

@anrddh
Copy link
Member

anrddh commented Sep 6, 2015

Fixing this.

@anrddh
Copy link
Member

anrddh commented Sep 6, 2015

The PR fixes the incorrect styling, but the dead link seems to be there on every waypoint so I guess it is intended?

@duffn
Copy link
Contributor Author

duffn commented Sep 6, 2015

The previous Waypoint (http://freecodecamp.com/challenges/waypoint-ditch-custom-css-for-bootstrap), says to:

...delete the p element that contains a dead link.

@anrddh
Copy link
Member

anrddh commented Sep 6, 2015

Crap, missed it. Let me update the PR. Thanks for the catch!

EDIT: done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants