Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not really a bug, just a comment on test wording #3130

Closed
rhyspowell opened this issue Sep 6, 2015 · 2 comments
Closed

Not really a bug, just a comment on test wording #3130

rhyspowell opened this issue Sep 6, 2015 · 2 comments
Assignees
@anrddh

Comments

@rhyspowell
Copy link

Challenge http://www.freecodecamp.com/challenges/waypoint-add-different-padding-to-each-side-of-an-element has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

Might have already been suggested but the wording for the actual tests isnt amazingly clear.

Dont mind taking a look if you think it is something that might need fixing
@anrddh
Copy link
Member

anrddh commented Sep 6, 2015

It looks clear enough to me?

What changes might you suggest?

@rhyspowell
Copy link
Author

looking back when not so tired, its not quite as bad possibly missing "the" from the sentences.

Your green-box class should give the top of the elements 40px of padding.

Not sure if the ext is auto generated in any way and needs to fit in multiple locations...

@benschenker benschenker added confirmed first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Sep 9, 2015
@anrddh anrddh self-assigned this Sep 9, 2015
@anrddh anrddh mentioned this issue Sep 9, 2015
Merged
@dcsan dcsan added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed confirmed labels Sep 9, 2015
@bugron bugron removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 9, 2015
QuincyLarson pushed a commit to QuincyLarson/freecodecamp that referenced this issue Sep 9, 2015
Fixed wording error in HTML/CSS waypoint
05864b4 
Waypoint 'Add Different Padding to Each Side of an Element' had a small wording error: the tests were missing `the`
closes freeCodeCamp#3130
@ghost ghost removed the first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anrddh anrddh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rhyspowell @dcsan @benschenker @anrddh @bugron