Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed btn-default. added btn-secondary #34224

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

revar532
Copy link
Contributor

@revar532 revar532 commented Nov 5, 2018

btn-default class has been renamed to btn-secondary in 4.0 verson and is no longer used.

  • [x ] I have read freeCodeCamp's contribution guidelines.
  • [ x] My pull request has a descriptive title (not a vague title like Update index.md)
  • [x ] My pull request targets the master branch of freeCodeCamp.
  • [ x] None of my changes are plagiarized from another source without proper attribution.
  • [x ] My article does not contain shortened URLs or affiliate links.

btn-default class has been renamed to btn-secondary in 4.0 verson and is no longer used.
Copy link
Member

@jonathan-grah jonathan-grah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 congratulations on your first PR 🎉

@jonathan-grah jonathan-grah merged commit 68d264a into freeCodeCamp:master Nov 5, 2018
@moT01
Copy link
Member

moT01 commented Nov 7, 2018

hey @jonathan-grah, we should QA the PR's starting with the oldest ones first.

@jonathan-grah
Copy link
Member

@moT01, yeah someone else mentioned that. will do 👍

@moT01
Copy link
Member

moT01 commented Nov 7, 2018

Thanks, it's not a problem - just trying to get everyone on the same page

matthew-beaty pushed a commit to matthew-beaty/freeCodeCamp that referenced this pull request Nov 14, 2018
btn-default class has been renamed to btn-secondary in 4.0 verson and is no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants